add QoS field to aws_iot_topic_rule republish action

[drexler]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12830

Release note for CHANGELOG:

add QoS field to aws_iot_topic_rule republish action

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSIoTTopicRule_republish'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSIoTTopicRule_republish -timeout 120m
=== RUN   TestAccAWSIoTTopicRule_republish
=== PAUSE TestAccAWSIoTTopicRule_republish
=== RUN   TestAccAWSIoTTopicRule_republish_with_qos
=== PAUSE TestAccAWSIoTTopicRule_republish_with_qos
=== CONT  TestAccAWSIoTTopicRule_republish
=== CONT  TestAccAWSIoTTopicRule_republish_with_qos
--- PASS: TestAccAWSIoTTopicRule_republish_with_qos (20.08s)
--- PASS: TestAccAWSIoTTopicRule_republish (20.35s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	20.429s

...

[bflad]

Hi @drexler 👋 Thank you for submitting this. I have fixed the merge conflicts since we just refactored the resource earlier today and this LGTM. 🚀

Output from acceptance testing:

--- PASS: TestAccAWSIoTTopicRule_iot_events (18.35s)
--- PASS: TestAccAWSIoTTopicRule_dynamoDbv2 (18.62s)
--- PASS: TestAccAWSIoTTopicRule_iot_analytics (18.69s)
--- PASS: TestAccAWSIoTTopicRule_lambda (18.81s)
--- PASS: TestAccAWSIoTTopicRule_basic (19.27s)
--- PASS: TestAccAWSIoTTopicRule_firehose (19.65s)
--- PASS: TestAccAWSIoTTopicRule_s3 (19.76s)
--- PASS: TestAccAWSIoTTopicRule_cloudwatchalarm (19.78s)
--- PASS: TestAccAWSIoTTopicRule_kinesis (19.85s)
--- PASS: TestAccAWSIoTTopicRule_republish (19.89s)
--- PASS: TestAccAWSIoTTopicRule_sns (19.97s)
--- PASS: TestAccAWSIoTTopicRule_sqs (19.98s)
--- PASS: TestAccAWSIoTTopicRule_elasticsearch (20.60s)
--- PASS: TestAccAWSIoTTopicRule_republish_with_qos (21.10s)
--- PASS: TestAccAWSIoTTopicRule_cloudwatchmetric (21.71s)
--- PASS: TestAccAWSIoTTopicRule_dynamodb (30.98s)
--- PASS: TestAccAWSIoTTopicRule_firehose_separator (31.69s)

[ghost]

This has been released in version 2.62.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!