resource/aws_route53_health_check: Validate reference_name #12873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
size/XS
bflad
suggested changes
Apr 17, 2020
bflad
added
enhancement
|
Hey @bflad, is there anything I need for this PR? |
ghost
removed
the
waiting-response
bflad
reviewed
Apr 23, 2020
|
Ooof! Okay, it should be good now. Thanks! |
Support plan-time validation for the length of the reference_name argument. Since this resource auto-appends a unique string to the provided argument, this is necessary to avoid obtuse errors on apply. This validates the provided reference_name plus the generated string is no longer than 64 chars, the actual API limit. Since the generated unique ID is 37 chars, the `reference_name` argument cannot exceed 27 characters. Closes #7248 Co-Authored-By: Brian Flad <bflad417@gmail.com>
bflad
approved these changes
Apr 29, 2020
There was a problem hiding this comment.
Looks great, thanks @timoguin 🚀
Output from acceptance testing:
--- PASS: TestAccAWSRoute53HealthCheck_disappears (9.61s)
--- PASS: TestAccAWSRoute53HealthCheck_withHealthCheckRegions (19.50s)
--- PASS: TestAccAWSRoute53HealthCheck_withChildHealthChecks (22.39s)
--- PASS: TestAccAWSRoute53HealthCheck_withSearchString (25.97s)
--- PASS: TestAccAWSRoute53HealthCheck_IpConfig (26.48s)
--- PASS: TestAccAWSRoute53HealthCheck_Ipv6Config (27.27s)
--- PASS: TestAccAWSRoute53HealthCheck_basic (29.14s)
--- PASS: TestAccAWSRoute53HealthCheck_CloudWatchAlarmCheck (29.42s)
--- PASS: TestAccAWSRoute53HealthCheck_tags (36.04s)
--- PASS: TestAccAWSRoute53HealthCheck_withSNI (37.91s)
bflad
added a commit
that referenced
this pull request
Apr 29, 2020
|
This has been released in version 2.60.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
adamdecaf
pushed a commit
to adamdecaf/terraform-provider-aws
that referenced
this pull request
May 28, 2020
Support plan-time validation for the length of the reference_name argument. Since this resource auto-appends a unique string to the provided argument, this is necessary to avoid obtuse errors on apply. This validates the provided reference_name plus the generated string is no longer than 64 chars, the actual API limit. Since the generated unique ID is 37 chars, the `reference_name` argument cannot exceed 27 characters. Closes hashicorp#7248 Co-Authored-By: Brian Flad <bflad417@gmail.com> Co-authored-by: Brian Flad <bflad417@gmail.com>
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Support plan-time validation for the length of the
reference_name argument. Since this resource auto-appends a unique string to the provided argument, this is necessary to avoid obtuse errors on apply. This ensures the providedreference_nameplus the generated string is no longer than 64 chars, the actual API limit.Since the generated unique ID is 26 chars, the
reference_nameargument cannot exceed 38 characters.Closes #7248
Release note for CHANGELOG:
Output from acceptance testing:
Output from Terraform run with patched build: