Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_lambda_alias resource: suppress diff for function_name #12902

Merged
merged 1 commit into from
Apr 20, 2020
Merged

aws_lambda_alias resource: suppress diff for function_name #12902

merged 1 commit into from
Apr 20, 2020

Conversation

angelyan
Copy link
Contributor

Using function name or ARN should be the same

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12901
Relates #12876

Release note for CHANGELOG:

resource/aws_lambda_alias: suppress diff for function_name

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSLambdaAlias'

...

@angelyan angelyan requested a review from a team April 20, 2020 16:44
@ghost ghost added size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/lambda Issues and PRs that pertain to the lambda service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 20, 2020
Using function name or ARN should be the same
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 20, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks so much, @angelyan 🚀

Output from acceptance testing:

--- PASS: TestAccAWSLambdaAlias_basic (39.20s)
--- PASS: TestAccAWSLambdaAlias_routingconfig (48.33s)
--- PASS: TestAccAWSLambdaAlias_nameupdate (50.40s)

@bflad bflad merged commit 2559c9e into hashicorp:master Apr 20, 2020
@bflad bflad added this to the v2.59.0 milestone Apr 20, 2020
bflad added a commit that referenced this pull request Apr 20, 2020
@ghost
Copy link

ghost commented Apr 24, 2020

This has been released in version 2.59.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented May 21, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/lambda Issues and PRs that pertain to the lambda service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_lambda_alias is recreated when function_name changes from function name to ARN and viceversa
2 participants