Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for importing aws_default_network_acl resources #12924

Merged
merged 4 commits into from
Apr 23, 2020
Merged

add support for importing aws_default_network_acl resources #12924

merged 4 commits into from
Apr 23, 2020

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Apr 21, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12911

Release note for CHANGELOG:

add import support for aws_default_network_acl resources

Output from acceptance testing:

--- PASS: TestAccAWSDefaultNetworkAcl_basic (32.27s)
--- PASS: TestAccAWSDefaultNetworkAcl_SubnetRemoval (77.36s)
--- PASS: TestAccAWSDefaultNetworkAcl_deny_ingress (95.97s)
--- PASS: TestAccAWSDefaultNetworkAcl_withIpv6Ingress (106.92s)
--- PASS: TestAccAWSDefaultNetworkAcl_basicIpv6Vpc (111.20s)
--- PASS: TestAccAWSDefaultNetworkAcl_SubnetReassign (156.05s)

@anGie44 anGie44 requested a review from a team April 21, 2020 16:23
@ghost ghost added size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 21, 2020
@ghost ghost added the service/ssm Issues and PRs that pertain to the ssm service. label Apr 22, 2020
@anGie44 anGie44 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 22, 2020
@anGie44
Copy link
Contributor Author

anGie44 commented Apr 22, 2020

quick note @bflad: i'll need to make changes to bring back the Checks as discussed in #12921 (review)

@ghost ghost added size/S Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Apr 22, 2020
bflad
bflad approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🚀

Output from acceptance testing:

--- PASS: TestAccAWSDefaultNetworkAcl_deny_ingress (11.97s)
--- PASS: TestAccAWSDefaultNetworkAcl_withIpv6Ingress (11.98s)
--- PASS: TestAccAWSDefaultNetworkAcl_basic (12.07s)
--- PASS: TestAccAWSDefaultNetworkAcl_basicIpv6Vpc (12.05s)
--- PASS: TestAccAWSDefaultNetworkAcl_SubnetRemoval (20.40s)
--- PASS: TestAccAWSDefaultNetworkAcl_SubnetReassign (22.45s)

@bflad bflad added this to the v2.59.0 milestone Apr 23, 2020
@anGie44 anGie44 merged commit 95f92b0 into master Apr 23, 2020
@anGie44 anGie44 deleted the ap_default_network_acl_import branch April 23, 2020 16:42
@ghost
Copy link

ghost commented Apr 24, 2020

This has been released in version 2.59.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented May 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators May 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. service/ssm Issues and PRs that pertain to the ssm service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.59.0
Development

Successfully merging this pull request may close these issues.

Support aws_default_network_acl Resource Import
2 participants
@anGie44 @bflad