Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service/rds: Fix schema panic errors #13362

Merged
merged 3 commits into from
May 19, 2020
Merged

service/rds: Fix schema panic errors #13362

merged 3 commits into from
May 19, 2020

Conversation

appilon
Copy link
Contributor

@appilon appilon commented May 15, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13312

Release note for CHANGELOG:

* d/aws_db_instance: 'auto_minor_version_upgrade' now properly set
* d/aws_rds_cluster: 'backtrack_window' attribute now available

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@appilon appilon requested a review from a team May 15, 2020 22:28
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/rds Issues and PRs that pertain to the rds service. labels May 15, 2020
@appilon appilon added the bug Addresses a defect in current functionality. label May 15, 2020
@ghost ghost added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label May 15, 2020
@bflad bflad self-assigned this May 18, 2020
bflad
bflad approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Output from acceptance testing:

--- PASS: TestAccDataSourceAWSRDSCluster_basic (125.32s)

--- PASS: TestAccAWSDbInstanceDataSource_basic (526.60s)

@appilon appilon merged commit 24eaad2 into master May 19, 2020
@appilon appilon deleted the b-rds-schema-panic branch May 19, 2020 16:54
bflad added a commit that referenced this pull request May 19, 2020
@bflad
Adjust CHANGELOG formatting for #13362
6a5d798 
Reference: https://www.terraform.io/docs/extend/best-practices/versioning.html#changelog-specification
@appilon appilon added this to the v2.63.0 milestone May 20, 2020
@ghost
Copy link

ghost commented May 22, 2020

This has been released in version 2.63.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

adamdecaf pushed a commit to adamdecaf/terraform-provider-aws that referenced this pull request May 28, 2020
@appilon @adamdecaf
service/rds: Fix schema panic errors (hashicorp#13362)
ee91b6b 
* Fix attribute typo to 'auto_minor_version_upgrade'

* Add 'backtrack_window' attribute to schema

* Add TestChecks
@ghost
Copy link

ghost commented Jun 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
bug Addresses a defect in current functionality. service/rds Issues and PRs that pertain to the rds service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.63.0
Development

Successfully merging this pull request may close these issues.
2 participants
@appilon @bflad