resource/aws_eks_node_group: Only pass ReleaseVersion during UpdateNodegroupVersion if changed #13407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…degroupVersion if changed Reference: #12675 It was expected to see an error similar to the issue report about the incompatible update and Terraform was previously submitting the state value for `release_version`, however the EKS API as of today was automatically fixing the incorrect value instead of returning an error. The resource change is to ensure that we will only submit correct API parameters should the API return errors for this situation in the future again. Output from acceptance testing: ``` --- PASS: TestAccAWSEksNodeGroup_disappears (1356.93s) --- PASS: TestAccAWSEksNodeGroup_InstanceTypes (1519.46s) --- PASS: TestAccAWSEksNodeGroup_ScalingConfig_MaxSize (1540.56s) --- PASS: TestAccAWSEksNodeGroup_DiskSize (1550.40s) --- PASS: TestAccAWSEksNodeGroup_basic (1581.83s) --- PASS: TestAccAWSEksNodeGroup_AmiType (1591.47s) --- PASS: TestAccAWSEksNodeGroup_RemoteAccess_SourceSecurityGroupIds (1602.60s) --- PASS: TestAccAWSEksNodeGroup_ScalingConfig_DesiredSize (1632.41s) --- PASS: TestAccAWSEksNodeGroup_ScalingConfig_MinSize (1683.52s) --- PASS: TestAccAWSEksNodeGroup_Tags (1712.30s) --- PASS: TestAccAWSEksNodeGroup_Labels (1765.19s) --- PASS: TestAccAWSEksNodeGroup_RemoteAccess_Ec2SshKey (1767.20s) --- PASS: TestAccAWSEksNodeGroup_ReleaseVersion (2853.92s) --- PASS: TestAccAWSEksNodeGroup_Version (3045.62s) ```
ghost
added
size/XS
anGie44
approved these changes
May 20, 2020
There was a problem hiding this comment.
🎉 LGTM @bflad !
Output of acceptance tests:
--- PASS: TestAccAWSEksNodeGroup_AmiType (1567.68s)
--- PASS: TestAccAWSEksNodeGroup_basic (1592.08s)
--- PASS: TestAccAWSEksNodeGroup_RemoteAccess_Ec2SshKey (1599.62s)
--- PASS: TestAccAWSEksNodeGroup_RemoteAccess_SourceSecurityGroupIds (1604.01s)
--- PASS: TestAccAWSEksNodeGroup_Labels (1604.46s)
--- PASS: TestAccAWSEksNodeGroup_ScalingConfig_MaxSize (1610.94s)
--- PASS: TestAccAWSEksNodeGroup_DiskSize (1625.74s)
--- PASS: TestAccAWSEksNodeGroup_disappears (1638.87s)
--- PASS: TestAccAWSEksNodeGroup_InstanceTypes (1641.80s)
--- PASS: TestAccAWSEksNodeGroup_Tags (1672.26s)
--- PASS: TestAccAWSEksNodeGroup_ScalingConfig_MinSize (1757.90s)
--- PASS: TestAccAWSEksNodeGroup_ScalingConfig_DesiredSize (1872.85s)
--- FAIL: TestAccAWSEksNodeGroup_ReleaseVersion (5898.64s) -- unrelated failure; looks like just a timeout related to subnet
--- FAIL: TestAccAWSEksNodeGroup_Version (6090.86s) -- unrelated failure looks like just a timeout related to subnet
|
This has been released in version 2.63.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
adamdecaf
pushed a commit
to adamdecaf/terraform-provider-aws
that referenced
this pull request
May 28, 2020
…degroupVersion if changed (hashicorp#13407) Reference: hashicorp#12675 It was expected to see an error similar to the issue report about the incompatible update and Terraform was previously submitting the state value for `release_version`, however the EKS API as of today was automatically fixing the incorrect value instead of returning an error. The resource change is to ensure that we will only submit correct API parameters should the API return errors for this situation in the future again. Output from acceptance testing: ``` --- PASS: TestAccAWSEksNodeGroup_disappears (1356.93s) --- PASS: TestAccAWSEksNodeGroup_InstanceTypes (1519.46s) --- PASS: TestAccAWSEksNodeGroup_ScalingConfig_MaxSize (1540.56s) --- PASS: TestAccAWSEksNodeGroup_DiskSize (1550.40s) --- PASS: TestAccAWSEksNodeGroup_basic (1581.83s) --- PASS: TestAccAWSEksNodeGroup_AmiType (1591.47s) --- PASS: TestAccAWSEksNodeGroup_RemoteAccess_SourceSecurityGroupIds (1602.60s) --- PASS: TestAccAWSEksNodeGroup_ScalingConfig_DesiredSize (1632.41s) --- PASS: TestAccAWSEksNodeGroup_ScalingConfig_MinSize (1683.52s) --- PASS: TestAccAWSEksNodeGroup_Tags (1712.30s) --- PASS: TestAccAWSEksNodeGroup_Labels (1765.19s) --- PASS: TestAccAWSEksNodeGroup_RemoteAccess_Ec2SshKey (1767.20s) --- PASS: TestAccAWSEksNodeGroup_ReleaseVersion (2853.92s) --- PASS: TestAccAWSEksNodeGroup_Version (3045.62s) ```
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #12675
Release note for CHANGELOG:
It was expected to see an error similar to the issue report about the incompatible update and Terraform was previously submitting the state value for
release_version, however the EKS API as of today was automatically fixing the incorrect value instead of returning an error. The resource change is to ensure that we will only submit correct API parameters should the API return errors for this situation in the future again.Output from acceptance testing: