Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Step Functions IoT action #13520

Merged
merged 2 commits into from
May 28, 2020
Merged

Add support for Step Functions IoT action #13520

merged 2 commits into from
May 28, 2020

Conversation

jhosteny
Copy link
Contributor

@jhosteny jhosteny commented May 27, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

Add support for Step Functions to aws_iot_topic_rule

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSIoTTopicRule_step_functions'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSIoTTopicRule_step_functions -timeout 120m
=== RUN   TestAccAWSIoTTopicRule_step_functions
=== PAUSE TestAccAWSIoTTopicRule_step_functions
=== CONT  TestAccAWSIoTTopicRule_step_functions
--- PASS: TestAccAWSIoTTopicRule_step_functions (27.10s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	27.120s

...

@jhosteny jhosteny requested a review from a team May 27, 2020 20:27
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/iot Issues and PRs that pertain to the iot service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. needs-triage Waiting for first response or review from a maintainer. labels May 27, 2020
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels May 28, 2020
@bflad bflad self-assigned this May 28, 2020
@bflad bflad added this to the v2.64.0 milestone May 28, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jhosteny 🚀

Output from acceptance testing:

--- PASS: TestAccAWSIoTTopicRule_cloudwatchmetric (17.14s)
--- PASS: TestAccAWSIoTTopicRule_kinesis (17.31s)
--- PASS: TestAccAWSIoTTopicRule_republish (17.95s)
--- PASS: TestAccAWSIoTTopicRule_iot_analytics (19.13s)
--- PASS: TestAccAWSIoTTopicRule_dynamoDbv2 (19.98s)
--- PASS: TestAccAWSIoTTopicRule_cloudwatchalarm (20.36s)
--- PASS: TestAccAWSIoTTopicRule_republish_with_qos (20.17s)
--- PASS: TestAccAWSIoTTopicRule_basic (20.64s)
--- PASS: TestAccAWSIoTTopicRule_sns (20.75s)
--- PASS: TestAccAWSIoTTopicRule_firehose (20.99s)
--- PASS: TestAccAWSIoTTopicRule_step_functions (21.03s)
--- PASS: TestAccAWSIoTTopicRule_lambda (21.38s)
--- PASS: TestAccAWSIoTTopicRule_elasticsearch (21.29s)
--- PASS: TestAccAWSIoTTopicRule_s3 (21.39s)
--- PASS: TestAccAWSIoTTopicRule_sqs (27.13s)
--- PASS: TestAccAWSIoTTopicRule_iot_events (27.23s)
--- PASS: TestAccAWSIoTTopicRule_dynamodb (28.99s)
--- PASS: TestAccAWSIoTTopicRule_firehose_separator (28.97s)
--- PASS: TestAccAWSIoTTopicRule_Tags (33.82s)

@bflad bflad merged commit 569fb51 into hashicorp:master May 28, 2020
bflad added a commit that referenced this pull request May 28, 2020
@ghost
Copy link

ghost commented May 29, 2020

This has been released in version 2.64.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jun 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/iot Issues and PRs that pertain to the iot service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants