resource/aws_rds_cluster: Allow setting of rds cluster engine #1415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: hashicorp#1412 In order to prepare for the creation of `postgres` rds clusters, the value of engine has been changed from readonly to optional (with a default of `aurora`) ``` % make testacc TEST=./aws TESTARGS='-run=TestAccAWSRDSCluster_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -run=TestAccAWSRDSCluster_ -timeout 120m === RUN TestAccAWSRDSCluster_importBasic --- PASS: TestAccAWSRDSCluster_importBasic (137.81s) === RUN TestAccAWSRDSCluster_basic --- PASS: TestAccAWSRDSCluster_basic (124.67s) === RUN TestAccAWSRDSCluster_namePrefix --- PASS: TestAccAWSRDSCluster_namePrefix (163.24s) === RUN TestAccAWSRDSCluster_generatedName --- PASS: TestAccAWSRDSCluster_generatedName (160.98s) === RUN TestAccAWSRDSCluster_takeFinalSnapshot --- PASS: TestAccAWSRDSCluster_takeFinalSnapshot (156.50s) === RUN TestAccAWSRDSCluster_missingUserNameCausesError --- PASS: TestAccAWSRDSCluster_missingUserNameCausesError (7.78s) === RUN TestAccAWSRDSCluster_updateTags --- PASS: TestAccAWSRDSCluster_updateTags (131.87s) === RUN TestAccAWSRDSCluster_updateIamRoles --- PASS: TestAccAWSRDSCluster_updateIamRoles (158.63s) === RUN TestAccAWSRDSCluster_kmsKey --- PASS: TestAccAWSRDSCluster_kmsKey (165.48s) === RUN TestAccAWSRDSCluster_encrypted --- PASS: TestAccAWSRDSCluster_encrypted (134.38s) === RUN TestAccAWSRDSCluster_backupsUpdate --- PASS: TestAccAWSRDSCluster_backupsUpdate (144.75s) === RUN TestAccAWSRDSCluster_iamAuth --- PASS: TestAccAWSRDSCluster_iamAuth (134.47s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 1620.571s ```
Ninir
approved these changes
Aug 15, 2017
|
@Ninir I believe this may need a changelog entry? Thoughts? |
nbaztec
pushed a commit
to nbaztec/terraform-provider-aws
that referenced
this pull request
Sep 26, 2017
…ngine-15803 resource/aws_rds_cluster: Allow setting of rds cluster engine
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1412
In order to prepare for the creation of
postgresrds clusters, thevalue of engine has been changed from readonly to optional (with a
default of
aurora)