Add stopped as a valid state for volume attachment

[bodgit]

Should fix #1311

[radeksimko]

Hi @bodgit
this looks reasonable, do you mind adding an acceptance test so we can be sure this bug is doesn't ever come back?

I assume we'll need to stop the instance as part of the test since we don't support stopped instances in Terraform at this point for various reasons.

Let me know if you need any help with writing the test or if you want me to do it - that's ok too.

[Ninir]

Hi @bodgit

Do you think you would have time to finish this work and add the acceptance test asked by @radeksimko ?
Would be much appreciated! :)

[bodgit]

I've added a test that passes:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSVolumeAttachment_attachStopped'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSVolumeAttachment_attachStopped -timeout 120m
=== RUN   TestAccAWSVolumeAttachment_attachStopped
--- PASS: TestAccAWSVolumeAttachment_attachStopped (199.85s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	199.880s

I also reverted my change and checked that the test also fails correctly.

[jen20]

Thanks for adding the test here - this looks good to me now!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!