Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data-source/docdb_orderable_db_instance: New data source #14931

Merged
merged 1 commit into from
Sep 1, 2020
Merged

data-source/docdb_orderable_db_instance: New data source #14931

merged 1 commit into from
Sep 1, 2020

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Aug 31, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14926

Release note for CHANGELOG:

* data-source/aws_docdb_orderable_db_instance: New data source to find valid DocumentDB instance
parameter combinations

Output from acceptance testing:

Testing on GovCloud:

--- PASS: TestAccAWSDocdbOrderableDbInstanceDataSource_basic (16.05s)
--- PASS: TestAccAWSDocdbOrderableDbInstanceDataSource_preferred (16.05s)

Testing on commercial/standard partition:

--- PASS: TestAccAWSDocdbOrderableDbInstanceDataSource_basic (11.66s)
--- PASS: TestAccAWSDocdbOrderableDbInstanceDataSource_preferred (12.95s)

@YakDriver YakDriver requested a review from a team August 31, 2020 19:25
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/docdb Issues and PRs that pertain to the docdb service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 31, 2020
@YakDriver YakDriver force-pushed the f-orderable-db branch 3 times, most recently from 75b1d09 to 98e02fe Compare August 31, 2020 19:30
@YakDriver
Copy link
Member Author

Post changes:

Commercial:

--- PASS: TestAccAWSDocdbOrderableDbInstanceDataSource_basic (11.78s)
--- PASS: TestAccAWSDocdbOrderableDbInstanceDataSource_preferred (12.96s)

GovCloud:

--- PASS: TestAccAWSDocdbOrderableDbInstanceDataSource_basic (16.14s)
--- PASS: TestAccAWSDocdbOrderableDbInstanceDataSource_preferred (16.79s)

@ghost ghost added size/L Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Aug 31, 2020
@YakDriver YakDriver force-pushed the f-orderable-db branch 2 times, most recently from 1a8e2da to 4a22dfd Compare August 31, 2020 22:50
@bflad bflad self-assigned this Aug 31, 2020
@bflad bflad added the new-data-source Introduces a new data source. label Aug 31, 2020
bflad
bflad approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just two little documentation suggestions. 🚀

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSDocdbOrderableDbInstanceDataSource_basic (11.98s)
--- PASS: TestAccAWSDocdbOrderableDbInstanceDataSource_preferred (12.71s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSDocdbOrderableDbInstanceDataSource_preferred (8.43s)
--- PASS: TestAccAWSDocdbOrderableDbInstanceDataSource_basic (8.50s)

website/docs/d/docdb_orderable_db_instance.markdown Outdated Show resolved Hide resolved
website/docs/d/docdb_orderable_db_instance.markdown Outdated Show resolved Hide resolved
@YakDriver YakDriver added the partition/aws-us-gov Pertains to the aws-us-gov partition. label Sep 1, 2020
@YakDriver YakDriver added this to the v3.5.0 milestone Sep 1, 2020
@YakDriver YakDriver merged commit ae3204c into master Sep 1, 2020
@YakDriver YakDriver deleted the f-orderable-db branch September 1, 2020 13:17
@ghost
Copy link

ghost commented Sep 3, 2020

This has been released in version 3.5.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. partition/aws-us-gov Pertains to the aws-us-gov partition. provider Pertains to the provider itself, rather than any interaction with AWS. service/docdb Issues and PRs that pertain to the docdb service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

data-source/aws_docdb_orderable_db_instance: New data source
2 participants
@YakDriver @bflad