resource/aws_ssm_association: Migrate the schema to use association_id #1579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The id of `aws_ssm_association` was currently stored as name but should have been association_id from the outside This PR introduces a new migration to update the ssm_association state to migrate to storing the id as the association_id rather than the name This will make it easier to implement the import of `aws_ssm_associations` ``` % make testacc TEST=./aws TESTARGS='-run=TestAccAWSSSMAssociation_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -run=TestAccAWSSSMAssociation_ -timeout 120m === RUN TestAccAWSSSMAssociation_basic --- PASS: TestAccAWSSSMAssociation_basic (138.40s) === RUN TestAccAWSSSMAssociation_withTargets --- PASS: TestAccAWSSSMAssociation_withTargets (37.27s) === RUN TestAccAWSSSMAssociation_withParameters --- PASS: TestAccAWSSSMAssociation_withParameters (59.31s) === RUN TestAccAWSSSMAssociation_withDocumentVersion --- PASS: TestAccAWSSSMAssociation_withDocumentVersion (38.17s) === RUN TestAccAWSSSMAssociation_withOutputLocation --- PASS: TestAccAWSSSMAssociation_withOutputLocation (164.86s) === RUN TestAccAWSSSMAssociation_withScheduleExpression --- PASS: TestAccAWSSSMAssociation_withScheduleExpression (59.66s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 497.700s ```
stack72
force-pushed
the
aws-ssm-association-migration
branch
from
0cf86c1
to
faa1b33
Compare
Ninir
added
the
enhancement
Ninir
approved these changes
Sep 11, 2017
There was a problem hiding this comment.
Hi @stack72
Looks awesome!
$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSSMAssociation_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSSSMAssociation_ -timeout 120m
=== RUN TestAccAWSSSMAssociation_basic
--- PASS: TestAccAWSSSMAssociation_basic (196.67s)
=== RUN TestAccAWSSSMAssociation_withTargets
--- PASS: TestAccAWSSSMAssociation_withTargets (57.78s)
=== RUN TestAccAWSSSMAssociation_withParameters
--- PASS: TestAccAWSSSMAssociation_withParameters (92.72s)
=== RUN TestAccAWSSSMAssociation_withDocumentVersion
--- PASS: TestAccAWSSSMAssociation_withDocumentVersion (56.96s)
=== RUN TestAccAWSSSMAssociation_withOutputLocation
--- PASS: TestAccAWSSSMAssociation_withOutputLocation (239.55s)
=== RUN TestAccAWSSSMAssociation_withScheduleExpression
--- PASS: TestAccAWSSSMAssociation_withScheduleExpression (90.03s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 733.756s
Also ran a manual test and everything seems perfect!
Thanks a LOT for your work 👍
nbaztec
pushed a commit
to nbaztec/terraform-provider-aws
that referenced
this pull request
Sep 26, 2017
…gration resource/aws_ssm_association: Migrate the schema to use association_id
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The id of
aws_ssm_associationwas currently stored as name but shouldhave been association_id from the outside
This PR introduces a new migration to update the ssm_association state
to migrate to storing the id as the association_id rather than the name
This will make it easier to implement the import of
aws_ssm_associations