Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_directory_service_directory: Support Import functionality #1732

Merged
merged 1 commit into from
Sep 25, 2017

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Sep 23, 2017

Fixes: #1709

terraform-provider-aws [b-aws-ds-import-1709●●] % acctests aws TestAccAWSDirectoryServiceDirectory_importBasic
=== RUN   TestAccAWSDirectoryServiceDirectory_importBasic
--- PASS: TestAccAWSDirectoryServiceDirectory_importBasic (589.56s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	589.594s

Fixes: hashicorp#1709

```
terraform-provider-aws [b-aws-ds-import-1709●●] % acctests aws TestAccAWSDirectoryServiceDirectory_importBasic
=== RUN   TestAccAWSDirectoryServiceDirectory_importBasic
--- PASS: TestAccAWSDirectoryServiceDirectory_importBasic (589.56s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	589.594s
```
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@tombuildsstuff tombuildsstuff added the enhancement Requests to existing resources that expand the functionality or scope. label Sep 25, 2017
@tombuildsstuff tombuildsstuff merged commit 97d6071 into hashicorp:master Sep 25, 2017
tombuildsstuff added a commit that referenced this pull request Sep 25, 2017
nbaztec pushed a commit to nbaztec/terraform-provider-aws that referenced this pull request Sep 26, 2017
resource/aws_directory_service_directory: Support Import functionality
nbaztec pushed a commit to nbaztec/terraform-provider-aws that referenced this pull request Sep 26, 2017
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_directory_service_directory isn't importable
2 participants