Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add states to pending list #1790

Merged
merged 3 commits into from
Oct 2, 2017
Merged

Add states to pending list #1790

merged 3 commits into from
Oct 2, 2017

Conversation

pradeepbhadani
Copy link
Contributor

Fixes #1789

@radeksimko radeksimko added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 2, 2017
radeksimko
radeksimko approved these changes Oct 2, 2017
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks ok, I just left you one comment.

aws/resource_aws_rds_cluster_instance.go Outdated
@@ -246,7 +246,7 @@ func resourceAwsRDSClusterInstanceCreate(d *schema.ResourceData, meta interface{

// reuse db_instance refresh func
stateConf := &resource.StateChangeConf{
Pending: []string{"creating", "backing-up", "modifying", "configuring-enhanced-monitoring"},
Pending: []string{"creating", "backing-up", "modifying", "configuring-enhanced-monitoring", "maintenance", "rebooting", "renaming", "resetting-master-credentials", "starting", "upgrading"},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really a nitpick, but do you mind line-wrapping this? i.e. put all the new pending states to the next line? I'll be easier to read that way.

@pradeepbhadani
Copy link
Contributor Author

@radeksimko Fixed formatting. It is now more readable.

@radeksimko radeksimko merged commit 15268c8 into hashicorp:master Oct 2, 2017
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add pending states to rds_cluster_instance resource
2 participants
@pradeepbhadani @radeksimko