New Data Source: aws_elasticsearch_domain

[marcboudreau]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #7899

This PR adds an AWS ElasticsearchDomain data source that can be used to retrieve any of the attributes returned by the describe-elasticsearch-domain API call or tags returned by the list-tags API call, by simply providing the domain_name.

I've successfully ran the acceptance test (targeting my new test only). However, I was unable to add a check for the tags.

I'm also including some missing punctuation in the AWS ElasticsearchDomain resource documentation page that I noticed.

[marcboudreau]

I've incorporated the feedback from the comments, and had to make some additional adjustments to the schema definition of the datasource (adding zone_awareness_config to the cluster_options).

Here are the outputs from the 2 acceptance test functions that I'm introducing:
Basic test

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataElasticsearchDomain_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSDataElasticsearchDomain_basic -timeout 120m
=== RUN   TestAccAWSDataElasticsearchDomain_basic
=== PAUSE TestAccAWSDataElasticsearchDomain_basic
=== CONT  TestAccAWSDataElasticsearchDomain_basic
--- PASS: TestAccAWSDataElasticsearchDomain_basic (802.63s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       802.680s

Advanced test

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataElasticsearchDomain_advanced'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSDataElasticsearchDomain_advanced -timeout 120m
=== RUN   TestAccAWSDataElasticsearchDomain_advanced
=== PAUSE TestAccAWSDataElasticsearchDomain_advanced
=== CONT  TestAccAWSDataElasticsearchDomain_advanced
--- PASS: TestAccAWSDataElasticsearchDomain_advanced (1075.80s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       1075.850s

[ryndaniels]

Hi @marcboudreau - thanks for the changes! Just one quick fix to the zone_awareness_config schema for consistency, and then it looks like this needs to be rebased against master to get rid of the big erb diff. If you could take care of those and verify the tests again, we can keep moving this forward. Thanks! 👍

[ryndaniels]

Suggested change

	Type: schema.TypeSet,
	Type: schema.TypeList,

This should probably be TypeList to be consistent with the data type in the resource (see here for reference) 🙂

[marcboudreau]

Ok, thanks for that. I remember pausing on this and debating it.

[ryndaniels]

It looks like this needs a rebase! 🙂

[marcboudreau]

Made the requested changes, and I realized that I hadn't documented the added zone_awareness_config attribute, so I did that too.
Acceptance test results:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataElasticsearchDomain_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSDataElasticsearchDomain_basic -timeout 120m
=== RUN   TestAccAWSDataElasticsearchDomain_basic
=== PAUSE TestAccAWSDataElasticsearchDomain_basic
=== CONT  TestAccAWSDataElasticsearchDomain_basic
--- PASS: TestAccAWSDataElasticsearchDomain_basic (799.97s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       800.034s
$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataElasticsearchDomain_advanced'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSDataElasticsearchDomain_advanced -timeout 120m
=== RUN   TestAccAWSDataElasticsearchDomain_advanced
=== PAUSE TestAccAWSDataElasticsearchDomain_advanced
=== CONT  TestAccAWSDataElasticsearchDomain_advanced
--- PASS: TestAccAWSDataElasticsearchDomain_advanced (1044.48s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       1044.545s

[ryndaniels]

Thanks again @marcboudreau! I went ahead and made some changes to the aws.erb myself to get it in line with the recent changes on master, since I know there was a lot to deal with there. Good catch on adding the zone_awareness_config to the docs as well. 🙂

Acceptance testing output:

--- PASS: TestAccAWSDataElasticsearchDomain_basic (746.56s)
--- PASS: TestAccAWSDataElasticsearchDomain_advanced (1545.41s)

[ghost]

This has been released in version 2.26.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!