r/aws_lb: Allow assigning EIP to network LB #1956
Merged
+145
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for slightly bigger scope of this PR, but it was necessary to make tests pass.
Passing allocation ID w/out subnet causes AWS API to return
500 Internal Server Error
and the SDK to retry for ~1-2 hours. The API bug was reported and acked by AWS support, so it replies with something more sensible, e.g. 400.NLBs create their own ENIs, like other load balancers, and leaves them around for a short while after deletion which upsets other depending resources as we try to clean them up - EIPs in this case:
As opposed to ALB's & ELB's ENIs we can't cleanup those ENIs, so I just added retry. 🤷♂️
Snippet from debug log
to prove that waiter is actually necessary & effective:
Test results