Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Data Source: aws_dynamodb_table #2062

Merged
merged 2 commits into from
Oct 27, 2017
Merged

New Data Source: aws_dynamodb_table #2062

merged 2 commits into from
Oct 27, 2017

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Oct 26, 2017

Closes #680

 make testacc TESTARGS='-run=TestAccDataSourceAwsDynamoDbTable_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccDataSourceAwsDynamoDbTable_basic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccDataSourceAwsDynamoDbTable_basic
--- PASS: TestAccDataSourceAwsDynamoDbTable_basic (45.79s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	45.823s

@bflad bflad mentioned this pull request Oct 26, 2017
Closed
@radeksimko radeksimko added the new-data-source Introduces a new data source. label Oct 26, 2017
Ninir
Ninir reviewed Oct 26, 2017
View reviewed changes
Copy link
Contributor

@Ninir Ninir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bflad

This looks pretty good :)

Just left a small nitpicks to address. Once done, will run tests & merge.

Thanks for the work! 🍺 🚀

website/docs/d/dynamodb_table.html.markdown Outdated
Provides a DynamoDB table data source.
---

# aws_elb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: wrong data source name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attack of the copypasta! 😄 update incoming

aws/data_source_aws_dynamodb_table_test.go
}

func testAccDataSourceAwsDynamoDbTableConfigBasic(tableName string) string {
return fmt.Sprintf(`resource "aws_dynamodb_table" "dynamodb_table_test" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the configuration so that is uses 2 spaces per indentation? this would stick with other resources/data sources.

Thanks :)

@bflad
Copy link
Contributor Author

bflad commented Oct 26, 2017

Updated!

Ninir
Ninir approved these changes Oct 27, 2017
View reviewed changes
Copy link
Contributor

@Ninir Ninir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @bflad :)

$ make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsDynamoDbTable_basic'                      
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccDataSourceAwsDynamoDbTable_basic -timeout 120m
=== RUN   TestAccDataSourceAwsDynamoDbTable_basic
--- PASS: TestAccDataSourceAwsDynamoDbTable_basic (48.72s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	48.759s



$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSDynamoDbTable_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSDynamoDbTable_ -timeout 120m
=== RUN   TestAccAWSDynamoDbTable_importBasic
--- PASS: TestAccAWSDynamoDbTable_importBasic (66.22s)
=== RUN   TestAccAWSDynamoDbTable_importTags
--- PASS: TestAccAWSDynamoDbTable_importTags (49.06s)
=== RUN   TestAccAWSDynamoDbTable_basic
--- PASS: TestAccAWSDynamoDbTable_basic (284.16s)
=== RUN   TestAccAWSDynamoDbTable_streamSpecification
--- PASS: TestAccAWSDynamoDbTable_streamSpecification (71.62s)
=== RUN   TestAccAWSDynamoDbTable_tags
--- PASS: TestAccAWSDynamoDbTable_tags (47.77s)
=== RUN   TestAccAWSDynamoDbTable_gsiUpdate
--- PASS: TestAccAWSDynamoDbTable_gsiUpdate (129.93s)
=== RUN   TestAccAWSDynamoDbTable_ttl
--- PASS: TestAccAWSDynamoDbTable_ttl (74.55s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	723.351s

@Ninir Ninir merged commit 0e1dc39 into hashicorp:master Oct 27, 2017
@ewbankkit ewbankkit mentioned this pull request Aug 21, 2018
Closed
@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ninir Ninir Ninir approved these changes

Assignees
No one assigned
Labels
new-data-source Introduces a new data source.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Data Source for aws_dynamodb_table
3 participants
@bflad @Ninir @radeksimko