validateBatchName should allow hyphens

[yzach]

Links to AWS docs
http://docs.aws.amazon.com/batch/latest/APIReference/API_CreateComputeEnvironment.html#Batch-CreateComputeEnvironment-request-computeEnvironmentName
http://docs.aws.amazon.com/batch/latest/APIReference/API_RegisterJobDefinition.html#Batch-RegisterJobDefinition-request-jobDefinitionName

[Ninir]

LGTM! Nice catch, thanks @yzach 🚀 👍

[toddZilla0130]

We also noticed this and I did a little more research into the matter, testing various edges when naming the 3 Batch resources. In addition to the above, I discovered that:

• names must begin with an alphanumeric
• job queues have the same naming rules as compute environments and job definitions.

The regex I came up with is this ^[0-9a-zA-Z]{1}[0-9a-zA-Z_\-]{0,127}$

and I added

ValidateFunc: validateBatchName,

to the name block of resourceAwsBatchJobQueue in resource_aws_batch_job_queue.go.

I had opened (and will close) this: #2108

but if you'd like me to follow up on the above with a new PR I will be happy to do so.

(The API docs for CreateJobQueue cite no naming restrictions but they most definitely exist.)

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!