Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/cloudwatch_log_group: Use ID as name #2190

Merged
merged 2 commits into from
Nov 7, 2017
Merged

r/cloudwatch_log_group: Use ID as name #2190

merged 2 commits into from
Nov 7, 2017

Conversation

atsushi-ishibashi
Copy link
Contributor

@atsushi-ishibashi atsushi-ishibashi commented Nov 6, 2017 •
edited
Loading

#1752
In resourceAwsCloudWatchLogGroupUpdate, d.Get("name") is required but when using name_prefix, it becomes empty.

make testacc TEST=./aws TESTARGS='-run=TestAccAWSCloudWatchLogGroup_namePrefix_retention'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSCloudWatchLogGroup_namePrefix_retention -timeout 120m
=== RUN   TestAccAWSCloudWatchLogGroup_namePrefix_retention
--- PASS: TestAccAWSCloudWatchLogGroup_namePrefix_retention (42.28s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	42.389s

Other tests passed.

make testacc TEST=./aws TESTARGS='-run=TestAccAWSCloudWatchLogGroup_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSCloudWatchLogGroup_ -timeout 120m
=== RUN   TestAccAWSCloudWatchLogGroup_importBasic
--- PASS: TestAccAWSCloudWatchLogGroup_importBasic (48.82s)
=== RUN   TestAccAWSCloudWatchLogGroup_basic
--- PASS: TestAccAWSCloudWatchLogGroup_basic (47.09s)
=== RUN   TestAccAWSCloudWatchLogGroup_namePrefix
--- PASS: TestAccAWSCloudWatchLogGroup_namePrefix (47.51s)
=== RUN   TestAccAWSCloudWatchLogGroup_namePrefix_retention
--- PASS: TestAccAWSCloudWatchLogGroup_namePrefix_retention (44.58s)
=== RUN   TestAccAWSCloudWatchLogGroup_generatedName
--- PASS: TestAccAWSCloudWatchLogGroup_generatedName (43.62s)
=== RUN   TestAccAWSCloudWatchLogGroup_retentionPolicy
--- PASS: TestAccAWSCloudWatchLogGroup_retentionPolicy (84.38s)
=== RUN   TestAccAWSCloudWatchLogGroup_multiple
--- PASS: TestAccAWSCloudWatchLogGroup_multiple (60.10s)
=== RUN   TestAccAWSCloudWatchLogGroup_disappears
--- PASS: TestAccAWSCloudWatchLogGroup_disappears (36.63s)
=== RUN   TestAccAWSCloudWatchLogGroup_tagging
--- PASS: TestAccAWSCloudWatchLogGroup_tagging (168.41s)
=== RUN   TestAccAWSCloudWatchLogGroup_kmsKey
--- PASS: TestAccAWSCloudWatchLogGroup_kmsKey (127.96s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	709.182s

@atsushi-ishibashi atsushi-ishibashi changed the title r/aws_cloudwatch_log_group: Use ID as name r/cloudwatch_log_group: Use ID as name Nov 6, 2017
Ninir
Ninir reviewed Nov 6, 2017
View reviewed changes
Copy link
Contributor

@Ninir Ninir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @atsushi-ishibashi

This seems good :)
Just left 2 things to fix before testing & merging.

Thanks for the work! 👍 😄

aws/resource_aws_cloudwatch_log_group_test.go Outdated
func testAccAWSCloudWatchLogGroup_namePrefix_retention(rName string) string {
return fmt.Sprintf(`
resource "aws_cloudwatch_log_group" "test" {
name_prefix = "tf-test-%s"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the indentation to use 2 spaces?

aws/resource_aws_cloudwatch_log_group_test.go Outdated
testAccCheckCloudWatchLogGroupExists("aws_cloudwatch_log_group.test", &lg),
resource.TestMatchResourceAttr("aws_cloudwatch_log_group.test", "name", regexp.MustCompile("^tf-test-")),
),
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add another section, so that the first one is a creation, and the second one an update?

@Ninir Ninir added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 6, 2017
@atsushi-ishibashi
Copy link
Contributor Author 

make testacc TEST=./aws TESTARGS='-run=TestAccAWSCloudWatchLogGroup_namePrefix_retention'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSCloudWatchLogGroup_namePrefix_retention -timeout 120m
=== RUN   TestAccAWSCloudWatchLogGroup_namePrefix_retention
--- PASS: TestAccAWSCloudWatchLogGroup_namePrefix_retention (57.20s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	57.265s

Ninir
Ninir approved these changes Nov 7, 2017
View reviewed changes
Copy link
Contributor

@Ninir Ninir left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @atsushi-ishibashi

This looks good to me, thanks for the work here! :)

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSCloudWatchLogGroup_namePrefix_retention'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSCloudWatchLogGroup_namePrefix_retention -timeout 120m
=== RUN   TestAccAWSCloudWatchLogGroup_namePrefix_retention
--- PASS: TestAccAWSCloudWatchLogGroup_namePrefix_retention (66.50s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	66.536s

@Ninir Ninir merged commit 6a3d5c6 into hashicorp:master Nov 7, 2017
@Ninir Ninir mentioned this pull request Nov 7, 2017
Closed
@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ninir Ninir Ninir approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atsushi-ishibashi @Ninir