resource/aws_rds_cluster_instance: Support Performance Insights #2331

kwent · 2017-11-17T00:17:37Z

Support Performance Insights for rds_cluster_instance

$ go test -run=TestAccAWSRDSClusterInstance_withInstancePerformanceInsights -timeout=30s -parallel=4 ./aws
ok  	github.com/terraform-providers/terraform-provider-aws/aws	0.056s

kwent · 2017-11-21T15:46:24Z

Any reviewers for this ?

Ninir

Hi @kwent

Thanks for the work here, the overall modifications look very good! :)

However, the new acceptance test if failing with:

=== RUN   TestAccAWSRDSClusterInstance_withInstancePerformanceInsights
--- FAIL: TestAccAWSRDSClusterInstance_withInstancePerformanceInsights (109.20s)
	testing.go:503: Step 0 error: Error applying: 1 error(s) occurred:
		
		* aws_rds_cluster_instance.cluster_instances: 1 error(s) occurred:
		
		* aws_rds_cluster_instance.cluster_instances: InvalidParameterCombination: Access denied to Performance Insights
			status code: 400, request id: 9417a2ac-c09d-4f9a-9d06-50c336ea6167

Is it because it can only runs on Aurora postgres engines?

(As per the documentation: http://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/USER_PerfInsights.html:

Amazon RDS Performance Insights is currently available only for use with Amazon Aurora (PostgreSQL).)

kwent · 2017-11-22T19:50:38Z

@Ninir Thanks. Yes probably ! I will fix the test.

Should i also check against the engine and notify the user that Performance Insights is only available for engine = aurora-postgresql or just let the API threw this error ?

…ostgresl engine

kwent · 2017-11-23T06:27:54Z

Hi @Ninir,

The PR should be in a much better place now. Let me know !

kwent · 2017-12-15T04:26:03Z

Any follow up on this ? cc @Ninir

How can i help ?

Regards

Ninir · 2017-12-15T11:43:46Z

Hi @kwent

Just ran your tests, and got:

--- FAIL: TestAccAWSRDSClusterInstance_withInstancePerformanceInsights (117.00s)
	testing.go:503: Step 0 error: Error applying: 1 error(s) occurred:
		
		* aws_rds_cluster_instance.cluster_instances: 1 error(s) occurred:
		
		* aws_rds_cluster_instance.cluster_instances: InvalidParameterCombination: Cannot find version 9.6.3 for aurora

Can you investigate please? thanks!

Cf. #2419

kwent · 2017-12-15T19:26:50Z

I believe i now fixed it. I followed #2419 recommendation.

kwent · 2017-12-20T19:44:11Z

@Ninir Mind relaunching the test ?

Ninir · 2017-12-21T19:14:54Z

Hi @kwent !

Sure, here is the result:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSRDSClusterInstance_withInstancePerformanceInsights'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSRDSClusterInstance_withInstancePerformanceInsights -timeout 120m
=== RUN   TestAccAWSRDSClusterInstance_withInstancePerformanceInsights
--- FAIL: TestAccAWSRDSClusterInstance_withInstancePerformanceInsights (116.18s)
	testing.go:503: Step 0 error: Error applying: 1 error(s) occurred:
		
		* aws_rds_cluster_instance.cluster_instances: 1 error(s) occurred:
		
		* aws_rds_cluster_instance.cluster_instances: InvalidParameterCombination: RDS does not support creating a DB instance with the following combination: DBInstanceClass=db.r3.large, Engine=aurora-postgresql, EngineVersion=9.6.3, LicenseModel=postgresql-license. For supported combinations of instance class and database engine version, see the documentation.
			status code: 400, request id: c6cfaa29-b903-4322-8cae-bb12b56a233f

Are you able to run those tests on your own? Tell me if you need any help on that :)
It's getting ready to cross to the finish line! 🚀

ColinHebert · 2017-12-21T19:48:14Z

aws/resource_aws_rds_cluster_instance_test.go

+  engine                  = "aurora-postgresql"
+  identifier              = "tf-cluster-instance-%d"
+  cluster_identifier      = "${aws_rds_cluster.default.id}"
+  instance_class          = "db.r3.large"


Postgresql works with r4 instances (not r3): https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/Concepts.DBInstanceClass.html

@ColinHebert Thanks ! Fixed.

Postgresql works with r4 instances (not r3): https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/Concepts.DBInstanceClass.html

To follow aws-sdk-go name convention

Ninir

Hi folks,

@kwent : just made a change to tests so that the one that was not passing do now. See the latest commit for that!

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSRDSClusterInstance_'                               

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSRDSClusterInstance_ -timeout 120m
=== RUN   TestAccAWSRDSClusterInstance_importBasic
--- PASS: TestAccAWSRDSClusterInstance_importBasic (686.87s)
=== RUN   TestAccAWSRDSClusterInstance_basic
--- PASS: TestAccAWSRDSClusterInstance_basic (1383.96s)
=== RUN   TestAccAWSRDSClusterInstance_namePrefix
--- PASS: TestAccAWSRDSClusterInstance_namePrefix (642.38s)
=== RUN   TestAccAWSRDSClusterInstance_generatedName
--- PASS: TestAccAWSRDSClusterInstance_generatedName (644.96s)
=== RUN   TestAccAWSRDSClusterInstance_kmsKey
--- PASS: TestAccAWSRDSClusterInstance_kmsKey (721.82s)
=== RUN   TestAccAWSRDSClusterInstance_disappears
--- PASS: TestAccAWSRDSClusterInstance_disappears (660.97s)
=== RUN   TestAccAWSRDSClusterInstance_withInstanceEnhancedMonitor
--- PASS: TestAccAWSRDSClusterInstance_withInstanceEnhancedMonitor (705.20s)
=== RUN   TestAccAWSRDSClusterInstance_withInstancePerformanceInsights
--- PASS: TestAccAWSRDSClusterInstance_withInstancePerformanceInsights (892.01s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	6338.228s

Thanks for the work and reactivity! :) 🚀

resource/aws_rds_cluster_instance: Support Performance Insights

bflad · 2018-01-12T15:39:55Z

This has been released in terraform-provider-aws version 1.7.0. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

ghost · 2020-04-08T17:49:32Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

Support Performance Insights for rds_cluster_instance

46bb4c4

Ninir added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 21, 2017

Ninir suggested changes Nov 22, 2017

View reviewed changes

kwent added 5 commits November 22, 2017 21:56

Set engine to aurora-postgresql in specs

4519ac5

testAccCheckAWSDBClusterInstanceAttributes is now supporting aurora-p…

e8a9a21

…ostgresl engine

Performance Insights for engine = aurora-postresql only

d9c063e

Typo -> aurora-postgresl to aurora-postgresql

87caccb

vet fixes

68351b4

Fix specs by specifying engine in aws_rds_cluster_instance

2f5b224

Cf. #2419

ColinHebert reviewed Dec 21, 2017

View reviewed changes

kwent and others added 3 commits December 21, 2017 12:08

db.r3.large to db.r4.large

0f52adc

Postgresql works with r4 instances (not r3): https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/Concepts.DBInstanceClass.html

enabled_performance_insights to performance_insights_enabled

20bbaf7

To follow aws-sdk-go name convention

Fixed RDS Cluster - performance insights test

4411de0

Ninir approved these changes Dec 22, 2017

View reviewed changes

Ninir changed the title ~~Support Performance Insights for rds_cluster_instance~~ resource/aws_rds_cluster_instance: Support Performance Insights Dec 22, 2017

Ninir merged commit af666ee into hashicorp:master Dec 22, 2017

kwent deleted the kwent/performance_insights branch December 22, 2017 21:03

erran pushed a commit to erran/terraform-provider-aws that referenced this pull request Dec 28, 2017

Support Performance Insights for rds_cluster_instance (hashicorp#2331)

b3e79d4

resource/aws_rds_cluster_instance: Support Performance Insights

bflad added this to the v1.7.0 milestone Jan 12, 2018

This was referenced Jan 16, 2018

Support for PerformanceInsights for aws_rds_cluster_instance #2312

Closed

resource/aws_rds_cluster_instance: PerformanceInsightsKMSKeyId is not necessarily an ARN #3014

Closed

ColinHebert mentioned this pull request Jan 17, 2018

resource/aws_rds_cluster_instance: Unable to modify performance insights key without updating the "enable parameter #3015

Closed

ghost locked and limited conversation to collaborators Apr 8, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

resource/aws_rds_cluster_instance: Support Performance Insights #2331

resource/aws_rds_cluster_instance: Support Performance Insights #2331

kwent commented Nov 17, 2017 •

edited by Ninir

Loading

kwent commented Nov 21, 2017

Ninir left a comment

kwent commented Nov 22, 2017

kwent commented Nov 23, 2017

kwent commented Dec 15, 2017

Ninir commented Dec 15, 2017

kwent commented Dec 15, 2017

kwent commented Dec 20, 2017

Ninir commented Dec 21, 2017

ColinHebert Dec 21, 2017 •

edited

Loading

kwent Dec 21, 2017

Ninir left a comment •

edited

Loading

bflad commented Jan 12, 2018

ghost commented Apr 8, 2020

resource/aws_rds_cluster_instance: Support Performance Insights #2331

resource/aws_rds_cluster_instance: Support Performance Insights #2331

Conversation

kwent commented Nov 17, 2017 • edited by Ninir Loading

Support Performance Insights for rds_cluster_instance

kwent commented Nov 21, 2017

Ninir left a comment

Choose a reason for hiding this comment

kwent commented Nov 22, 2017

kwent commented Nov 23, 2017

kwent commented Dec 15, 2017

Ninir commented Dec 15, 2017

kwent commented Dec 15, 2017

kwent commented Dec 20, 2017

Ninir commented Dec 21, 2017

ColinHebert Dec 21, 2017 • edited Loading

Choose a reason for hiding this comment

kwent Dec 21, 2017

Choose a reason for hiding this comment

Ninir left a comment • edited Loading

Choose a reason for hiding this comment

bflad commented Jan 12, 2018

ghost commented Apr 8, 2020

kwent commented Nov 17, 2017 •

edited by Ninir

Loading

ColinHebert Dec 21, 2017 •

edited

Loading

Ninir left a comment •

edited

Loading