Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_cognito_identity_pool_roles_attachment: Fix typo "authenticated" -> "unauthenticated" #2358

Merged
merged 3 commits into from
Nov 20, 2017

Conversation

atsushi-ishibashi
Copy link
Contributor

Fix: #2356
Add a test case for unauthenticated role

make testacc TEST=./aws TESTARGS='-run=TestAccAWSCognitoIdentityPoolRolesAttachment_unauthenticated'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSCognitoIdentityPoolRolesAttachment_unauthenticated -timeout 120m
=== RUN   TestAccAWSCognitoIdentityPoolRolesAttachment_unauthenticated
--- PASS: TestAccAWSCognitoIdentityPoolRolesAttachment_unauthenticated (88.01s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	88.049s

@atsushi-ishibashi
Copy link
Contributor Author

Or should I add only test for validateCognitoRoles?

@Ninir Ninir added the bug Addresses a defect in current functionality. label Nov 20, 2017
@Ninir
Copy link
Contributor

Ninir commented Nov 20, 2017

Hi @atsushi-ishibashi

A Unit test is sufficient here :)

Can you make the change so that I review & merge?

Thanks for the work!

@atsushi-ishibashi
Copy link
Contributor Author

@Ninir Ok👍

@Ninir Ninir merged commit 5a0e84b into hashicorp:master Nov 20, 2017
@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to Assign Unauthenticated Role in Cognito Role Attachements
2 participants