resource/aws_api_gateway_method_response: Fix conflict exception in API gateway method response #2393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@betabandido - LGTM. This was the bane of my life when I'm building terraform that deploys API Gateway instances. I'd been running a hacked version of the provider locally with essentially the same change applied - though I used really aggressive retries, rather than a lock, because I was looking to go fast where possible. Would happily switch over to this though. |
Ninir
approved these changes
Nov 21, 2017
There was a problem hiding this comment.
Hi @betabandido
This looks very good to me! thanks a lot for the work! 👍 🤖 🚀
$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAPIGatewayRestApi_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSAPIGatewayRestApi_ -timeout 120m
=== RUN TestAccAWSAPIGatewayRestApi_basic
--- PASS: TestAccAWSAPIGatewayRestApi_basic (21.51s)
=== RUN TestAccAWSAPIGatewayRestApi_openapi
--- PASS: TestAccAWSAPIGatewayRestApi_openapi (34.83s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 56.386s
make testacc TEST=./aws TESTARGS='-run=TestAccAWSAPIGatewayMethodResponse_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSAPIGatewayMethodResponse_ -timeout 120m
=== RUN TestAccAWSAPIGatewayMethodResponse_basic
--- PASS: TestAccAWSAPIGatewayMethodResponse_basic (26.04s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 26.074s
Ninir
changed the title
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hopefully fixes #483
I have added a mutex to prevent concurrent method response creations. As this does not help with simultaneous executions of terraform (e.g., multiple developers deploying to the same AWS account), I have also added a retry block.
@radeksimko @steve-gray Does this look good to you?