Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/elasticache_parameter_group: Add StateFunc to make name lowercase #2426

Merged
merged 3 commits into from
Nov 30, 2017
Merged

r/elasticache_parameter_group: Add StateFunc to make name lowercase #2426

merged 3 commits into from
Nov 30, 2017

Conversation

atsushi-ishibashi
Copy link
Contributor

Fixed: #2139

@radeksimko
Copy link
Member

Thanks for the bugfix @atsushi-ishibashi

Do you mind attaching an acceptance test with name that has at least one uppercase character?

@radeksimko radeksimko added bug Addresses a defect in current functionality. waiting-response Maintainers are waiting on response from community or contributor. labels Nov 26, 2017
@atsushi-ishibashi
Copy link
Contributor Author 

make testacc TEST=./aws TESTARGS='-run=TestAccAWSElasticacheParameterGroup_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSElasticacheParameterGroup_ -timeout 120m
=== RUN   TestAccAWSElasticacheParameterGroup_importBasic
--- PASS: TestAccAWSElasticacheParameterGroup_importBasic (32.09s)
=== RUN   TestAccAWSElasticacheParameterGroup_basic
--- PASS: TestAccAWSElasticacheParameterGroup_basic (50.65s)
=== RUN   TestAccAWSElasticacheParameterGroup_only
--- PASS: TestAccAWSElasticacheParameterGroup_only (26.10s)
=== RUN   TestAccAWSElasticacheParameterGroup_removeParam
--- PASS: TestAccAWSElasticacheParameterGroup_removeParam (48.50s)
=== RUN   TestAccAWSElasticacheParameterGroup_UppercaseName
--- PASS: TestAccAWSElasticacheParameterGroup_UppercaseName (28.62s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	186.032s

@radeksimko radeksimko removed the waiting-response Maintainers are waiting on response from community or contributor. label Nov 27, 2017
Ninir
Ninir reviewed Nov 29, 2017
View reviewed changes
aws/resource_aws_elasticache_parameter_group_test.go Outdated
func testAccAWSElasticacheParameterGroupConfig_UppercaseName(rName string) string {
return fmt.Sprintf(`
resource "aws_elasticache_parameter_group" "bar" {
name = "%s"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: do you mind fixing the indentation to 2 spaces? thanks!

Ninir
Ninir approved these changes Nov 30, 2017
View reviewed changes
Copy link
Contributor

@Ninir Ninir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @atsushi-ishibashi

This looks very good to me! Thanks for the whole work here, as always! :)

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSElasticacheParameterGroup_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSElasticacheParameterGroup_ -timeout 120m
=== RUN   TestAccAWSElasticacheParameterGroup_importBasic
--- PASS: TestAccAWSElasticacheParameterGroup_importBasic (33.34s)
=== RUN   TestAccAWSElasticacheParameterGroup_basic
--- PASS: TestAccAWSElasticacheParameterGroup_basic (57.50s)
=== RUN   TestAccAWSElasticacheParameterGroup_only
--- PASS: TestAccAWSElasticacheParameterGroup_only (30.87s)
=== RUN   TestAccAWSElasticacheParameterGroup_removeParam
--- PASS: TestAccAWSElasticacheParameterGroup_removeParam (54.40s)
=== RUN   TestAccAWSElasticacheParameterGroup_UppercaseName
--- PASS: TestAccAWSElasticacheParameterGroup_UppercaseName (33.17s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	209.315s

@Ninir Ninir merged commit cf83b11 into hashicorp:master Nov 30, 2017
mdlavin pushed a commit to mdlavin/terraform-provider-aws that referenced this pull request Dec 9, 2017
@atsushi-ishibashi @mdlavin
r/elasticache_parameter_group: Add StateFunc to make name lowercase (h…
97486d2 
…ashicorp#2426)

* Add statefunc to make lowercase

* Add acceptance test

* Use 2 spaces instead of indentation
@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ninir Ninir Ninir approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws_elasticache_parameter_group Upper case letters throws exception
3 participants
@atsushi-ishibashi @radeksimko @Ninir