Support switching VPC tenancy from Dedicated to Default

[ewbankkit]

Fixes #1955.
N.B. This adds a requirement on the IAM ec2:ModifyVpcTenancy action.

[ewbankkit]

Rebased to correct conflicts.

Acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSVpc_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -run=TestAccAWSVpc_ -timeout 120m
=== RUN   TestAccAWSVpc_coreMismatchedDiffs
--- PASS: TestAccAWSVpc_coreMismatchedDiffs (36.50s)
=== RUN   TestAccAWSVpc_importBasic
--- PASS: TestAccAWSVpc_importBasic (43.93s)
=== RUN   TestAccAWSVpc_basic
--- PASS: TestAccAWSVpc_basic (37.59s)
=== RUN   TestAccAWSVpc_enableIpv6
--- PASS: TestAccAWSVpc_enableIpv6 (98.54s)
=== RUN   TestAccAWSVpc_dedicatedTenancy
--- PASS: TestAccAWSVpc_dedicatedTenancy (36.67s)
=== RUN   TestAccAWSVpc_modifyTenancy
--- PASS: TestAccAWSVpc_modifyTenancy (112.87s)
=== RUN   TestAccAWSVpc_tags
--- PASS: TestAccAWSVpc_tags (68.48s)
=== RUN   TestAccAWSVpc_update
--- PASS: TestAccAWSVpc_update (70.76s)
=== RUN   TestAccAWSVpc_bothDnsOptionsSet
--- PASS: TestAccAWSVpc_bothDnsOptionsSet (40.09s)
=== RUN   TestAccAWSVpc_DisabledDnsSupport
--- PASS: TestAccAWSVpc_DisabledDnsSupport (37.69s)
=== RUN   TestAccAWSVpc_classiclinkOptionSet
--- PASS: TestAccAWSVpc_classiclinkOptionSet (37.30s)
=== RUN   TestAccAWSVpc_classiclinkDnsSupportOptionSet
--- PASS: TestAccAWSVpc_classiclinkDnsSupportOptionSet (38.48s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	659.480s

[bflad]

Looks great, thanks @ewbankkit! 🚀

12 tests passed (all tests)
=== RUN   TestAccAWSVpc_classiclinkOptionSet
--- PASS: TestAccAWSVpc_classiclinkOptionSet (16.09s)
=== RUN   TestAccAWSVpc_DisabledDnsSupport
--- PASS: TestAccAWSVpc_DisabledDnsSupport (19.01s)
=== RUN   TestAccAWSVpc_coreMismatchedDiffs
--- PASS: TestAccAWSVpc_coreMismatchedDiffs (19.20s)
=== RUN   TestAccAWSVpc_classiclinkDnsSupportOptionSet
--- PASS: TestAccAWSVpc_classiclinkDnsSupportOptionSet (21.71s)
=== RUN   TestAccAWSVpc_importBasic
--- PASS: TestAccAWSVpc_importBasic (22.48s)
=== RUN   TestAccAWSVpc_basic
--- PASS: TestAccAWSVpc_basic (22.46s)
=== RUN   TestAccAWSVpc_dedicatedTenancy
--- PASS: TestAccAWSVpc_dedicatedTenancy (24.21s)
=== RUN   TestAccAWSVpc_tags
--- PASS: TestAccAWSVpc_tags (24.62s)
=== RUN   TestAccAWSVpc_update
--- PASS: TestAccAWSVpc_update (26.53s)
=== RUN   TestAccAWSVpc_modifyTenancy
--- PASS: TestAccAWSVpc_modifyTenancy (33.97s)
=== RUN   TestAccAWSVpc_bothDnsOptionsSet
--- PASS: TestAccAWSVpc_bothDnsOptionsSet (34.65s)
=== RUN   TestAccAWSVpc_enableIpv6
--- PASS: TestAccAWSVpc_enableIpv6 (36.17s)

[bflad]

This has been released in version 1.25.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!