Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lb_target_group health check inconsistencies #2580

Merged

Conversation

eguven
Copy link
Contributor

@eguven eguven commented Dec 7, 2017

  • path defaults to "/" (which is what docs say) and validate function checks for "/" prefix (from AWS: "The destination path for health checks. This path must begin with a '/' character, and can be at most 1024 characters in length."
  • timeout doc reflects the actual default (10) in code. AWS default is actually 5 but I did not want to change that and possibly break users' configuration.

When path is not provided the following error is produced:

Error: Error applying plan:

1 error(s) occurred:

aws_alb_target_group.some-tg-name: Error creating LB Target Group: InvalidParameter: 1 validation error(s) found.
- minimum field size of 1, CreateTargetGroupInput.HealthCheckPath.

@radeksimko radeksimko added the bug Addresses a defect in current functionality. label Dec 12, 2017
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @eguven
thanks for the PR.

I'm ok with the docs update and validation improvement.

Do you mind removing the Default for path (i.e. leaving it as is)?

@@ -132,6 +132,7 @@ func resourceAwsLbTargetGroup() *schema.Resource {
"path": {
Type: schema.TypeString,
Optional: true,
Default: "/",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was intentionally removed in order to bring support for network load balancers where path is irrelevant.

See 79467dc#diff-375aea487c27a6ada86edfd817ba2401

@radeksimko radeksimko added enhancement Requests to existing resources that expand the functionality or scope. waiting-response Maintainers are waiting on response from community or contributor. and removed bug Addresses a defect in current functionality. labels Dec 12, 2017
* path defaults to "/" and validate function checks for "/" prefix
* timeout doc reflects the actual default in code
@eguven eguven force-pushed the fix-lb_target_group-inconsistencies branch from a62f8a6 to 1e52ada Compare December 14, 2017 11:06
@eguven
Copy link
Contributor Author

eguven commented Dec 14, 2017

@radeksimko Thanks for the response, done. I hadn't considered network load balancers, sorry.

@radeksimko radeksimko merged commit 4b56a73 into hashicorp:master Jan 3, 2018
@bflad
Copy link
Contributor

bflad commented Jan 12, 2018

This has been released in terraform-provider-aws version 1.7.0. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@bflad bflad added this to the v1.7.0 milestone Jan 12, 2018
@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
@breathingdust breathingdust removed the waiting-response Maintainers are waiting on response from community or contributor. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants