-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix lb_target_group health check inconsistencies #2580
fix lb_target_group health check inconsistencies #2580
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @eguven
thanks for the PR.
I'm ok with the docs update and validation improvement.
Do you mind removing the Default for path
(i.e. leaving it as is)?
aws/resource_aws_lb_target_group.go
Outdated
@@ -132,6 +132,7 @@ func resourceAwsLbTargetGroup() *schema.Resource { | |||
"path": { | |||
Type: schema.TypeString, | |||
Optional: true, | |||
Default: "/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was intentionally removed in order to bring support for network load balancers where path is irrelevant.
* path defaults to "/" and validate function checks for "/" prefix * timeout doc reflects the actual default in code
a62f8a6
to
1e52ada
Compare
@radeksimko Thanks for the response, done. I hadn't considered network load balancers, sorry. |
This has been released in terraform-provider-aws version 1.7.0. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
When
path
is not provided the following error is produced: