resource/rds_cluster_instance: Support availability_zone

[atsushi-ishibashi]

Closes #2642

[radeksimko]

Thanks for the PR @atsushi-ishibashi

Do you mind adding an acceptance test which involves availability_zone set to non-empty value? e.g. first AZ from the AZ data source?

[atsushi-ishibashi]

If I use data "aws_availability_zones", it seemed to be difficult to check resource attribute so I specified the constant.

TF_ACC=1 go test ./aws -v -run=TestAccAWSRDSClusterInstance_az -timeout 120m
=== RUN   TestAccAWSRDSClusterInstance_az
--- PASS: TestAccAWSRDSClusterInstance_az (799.15s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	799.194s

[radeksimko]

@atsushi-ishibashi Thanks for the update.

I understand it's difficult to reference the resource attribute, but the problem is that this test is now pinned to us-west-2 and more importantly may not run in all accounts as AWS often assigns different AZ names to different accounts.

How do you feel about using the AZ data source? e.g.

data "aws_availability_zones" "available" {}

resource "aws_rds_cluster" "default" {
...
  availability_zones = ["${data.aws_availability_zones.available.names}"]
...
}

resource "aws_rds_cluster_instance" "cluster_instances" {
...
  availability_zone       = "${data.aws_availability_zones.available.names[0]}"
...

[atsushi-ishibashi]

Sure👍
But how should I write the below line? @radeksimko
https://github.com/terraform-providers/terraform-provider-aws/pull/2812/files#diff-e2a347e0fe3dfd86606d211eb111c503R66

The main purpose of this test is to confirm whether the specified az is set as availability_zone.

[radeksimko]

It's ok to check this more loosely, e.g.

resource.TestMatchResourceAttr("aws_rds_cluster_instance.cluster_instances", "availability_zone", regexp.MustCompile("^us-west-2[a-z]{1}$")

[atsushi-ishibashi]

I got it👍

[atsushi-ishibashi]

@radeksimko Updated👍

TF_ACC=1 go test ./aws -v -run=TestAccAWSRDSClusterInstance_az -timeout 120m
=== RUN   TestAccAWSRDSClusterInstance_az
--- PASS: TestAccAWSRDSClusterInstance_az (920.21s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	**920.255s**

[radeksimko]

LGTM, thanks.

[bflad]

This has been released in version 1.10.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!