r/ssm_maintenance_window: Fix ssm maintenance window #2818
Conversation
There was a problem hiding this comment.
This is looking good, thanks for the work :)
Just left a comment to discuss the need of a change. Otherwise: 👍
$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSSMMaintenanceWindow_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSSSMMaintenanceWindow_ -timeout 120m
=== RUN TestAccAWSSSMMaintenanceWindow_basic
--- PASS: TestAccAWSSSMMaintenanceWindow_basic (50.90s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 50.942s
aws/resource_aws_cloudtrail.go
Outdated
| @@ -99,7 +99,7 @@ func resourceAwsCloudTrailCreate(d *schema.ResourceData, meta interface{}) error | |||
| if v, ok := d.GetOk("cloud_watch_logs_role_arn"); ok { | |||
| input.CloudWatchLogsRoleArn = aws.String(v.(string)) | |||
| } | |||
| if v, ok := d.GetOk("include_global_service_events"); ok { | |||
| if v, ok := d.GetOkExists("include_global_service_events"); ok { | |||
There was a problem hiding this comment.
Not sure this change needs to be part of this work. Can you confirm @atsushi-ishibashi?
atsushi-ishibashi
force-pushed
the
fix-ssm_maintenance_window
branch
from
cb96287
to
10895f9
Compare
|
@Ninir Ok👍 |
|
Just reran the mentioned acceptance test, all good, so I'll merge this as I plan to look into one bug in this resource (and avoid conflicts :) ). @Ninir I hope you don't mind. |
|
Thanks @atsushi-ishibashi for the PR! |
|
This has been released in terraform-provider-aws version 1.7.0. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
enabledisn't set correctly via create cycle.