New Data Source: aws_security_groups

[ian-d]

Resolves #2740.

Using the data sources aws_instance/aws_instances naming convention, this creates an aws_security_groups data source for multiple security groups to complement the aws_security_group data source that fetches single security groups.

The example code in the documentation could use an example of creating a resource actually using the data source but I couldn't think of a concise AWS resource that uses a list of security groups that would make much sense in context.

Tests:

make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsSecurityGroups_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccDataSourceAwsSecurityGroups_ -timeout 120m
=== RUN   TestAccDataSourceAwsSecurityGroups_tag
--- PASS: TestAccDataSourceAwsSecurityGroups_tag (24.85s)
=== RUN   TestAccDataSourceAwsSecurityGroups_filter
--- PASS: TestAccDataSourceAwsSecurityGroups_filter (25.24s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	50.130s

[sdot257]

Any idea as to when this would merge? We need this functionality.

I have no experience with Golang, but I was able to build the provider into a binary file. I'm not sure how to actually use it.

[bflad]

Thanks for submitting this @ian-d! Overall it looks really good, just left some minor notes below which I can quickly fix up post-merge. 🚀

[bflad]

This new variable and logic surrounding it is extraneous, you can directly map the new resp.NextToken onto req.NextToken, e.g.

for {
  resp, err := conn.DescribeSecurityGroups(req)
  if err != nil {
    return fmt.Errorf("error reading security groups: %s", err)
  }
  for _, sg := range resp.SecurityGroups {
    ids = append(ids, aws.StringValue(sg.GroupId))
    vpc_ids = append(vpc_ids, aws.StringValue(sg.VpcId))
  }
  if resp.NextToken == nil {
    break
  }
  req.NextToken = resp.NextToken
}

[bflad]

We don't expect most folks to know this, but an odd side effect of having the singular and plural data sources is that both entries will be highlighted in the sidebar if you are on the singular data source page since the sidebar_current prefix matches both. Our current convention is to go back to the singular data source and append -x to the sidebar_current in both the sidebar and singular data source page.

[bflad]

Typo 😎 : missing s in data source name

[bflad]

This has been released in version 1.25.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!