resource/aws_eip_assocation: Retry association for pending instances

[bflad]

Closes #74
Closes #3041

Created failing acceptance test:

 make testacc TEST=./aws TESTARGS='-run=TestAccAWSEIPAssociation_spotInstance'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSEIPAssociation_spotInstance -timeout 120m
=== RUN   TestAccAWSEIPAssociation_spotInstance
--- FAIL: TestAccAWSEIPAssociation_spotInstance (83.92s)
	testing.go:513: Step 0 error: Error applying: 1 error(s) occurred:

		* aws_eip_association.test: 1 error(s) occurred:

		* aws_eip_association.test: [WARN] Error attaching EIP, message: "The pending instance 'i-0fd1d57b0b3e9ea0a' is not in a valid state for this operation.", code: "InvalidInstanceID"
FAIL
exit status 1
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	83.975s
make: *** [testacc] Error 1

Trying with an initial timeout of 1 minute reproduced similar issue (so bumped it to 2 minutes):

--- FAIL: TestAccAWSEIPAssociation_spotInstance (93.54s)
	testing.go:513: Step 0 error: Error applying: 1 error(s) occurred:

		* aws_eip_association.test: 1 error(s) occurred:

		* aws_eip_association.test: Error associating EIP: InvalidInstanceID: The pending instance 'i-00b32500bb43162da' is not in a valid state for this operation.
			status code: 400, request id: ed0f8b80-d8f6-4b41-8a00-42d2309694ae

Passes testing for me now:

make testacc TEST=./aws TESTARGS='-run=TestAccAWSEIPAssociation'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSEIPAssociation -timeout 120m
=== RUN   TestAccAWSEIPAssociation_basic
--- PASS: TestAccAWSEIPAssociation_basic (145.97s)
=== RUN   TestAccAWSEIPAssociation_ec2Classic
--- PASS: TestAccAWSEIPAssociation_ec2Classic (190.02s)
=== RUN   TestAccAWSEIPAssociation_spotInstance
--- PASS: TestAccAWSEIPAssociation_spotInstance (203.60s)
=== RUN   TestAccAWSEIPAssociation_disappears
--- PASS: TestAccAWSEIPAssociation_disappears (112.22s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	651.856s

[radeksimko]

LGTM 👍

[bflad]

This has been released in terraform-provider-aws version 1.8.0. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!