Store all config-specified DB params in state. #3182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, only database parameters that AWS recognised as being user-altered were stored in state. This would be fine, except if users specified the same value for a parameter as AWS' default for that value, they would get a perpetual diff, because AWS would report it as a non-user-changed parameter. Meaning it wouldn't be set in state, no matter how many times the user applied. This fixes the problem by retrieving all parameters, regardless of how AWS reports them being set. We then select out from those parameters only the ones that report that they're user-modified _or_ those that are found in a config, if a config is available. This commit also adds a test which exhibits this behaviour, which failed before this fix was applied, and passes now that it has been applied.
catsby
approved these changes
Jan 29, 2018
| } | ||
| } | ||
|
|
||
| d.Set("parameter", flattenParameters(userParams)) |
There was a problem hiding this comment.
Check the error here please
Because our parameters are a set, let's just check the error when setting them in state, just in case.
|
Believe I addressed the request, happy with the resolution of it? |
|
This has been released in terraform-provider-aws version 1.9.0. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, only database parameters that AWS recognised as
being user-altered were stored in state. This would be fine, except if
users specified the same value for a parameter as AWS' default for that
value, they would get a perpetual diff, because AWS would report it as a
non-user-changed parameter. Meaning it wouldn't be set in state, no
matter how many times the user applied.
This fixes the problem by retrieving all parameters, regardless of how
AWS reports them being set. We then select out from those parameters
only the ones that report that they're user-modified or those that are
found in a config, if a config is available.
This commit also adds a test which exhibits this behaviour, which failed
before this fix was applied, and passes now that it has been applied.
Test output:
Fixes #593.