New Resource: aws_dynamodb_table_item #3238

radeksimko · 2018-02-02T11:07:27Z

Replacement for #1378

Closes #517

This is a rough summary of my changes I added on top of @galadriel2143's PR:

Use standard retry helpers
Simplify code by extracting code into reusable functions
Remove fields which seemed unnecessary - if there's any interest we can add them later, but I think they'd unnecessarily increase the complexity of otherwise simple resource
Add validation
Add missing acceptance tests
Add missing docs

The original commit was retained, so @galadriel2143 can still receive the credit they deserve. 😉

Test results

=== RUN   TestAccAWSDynamoDbTableItem_basic
--- PASS: TestAccAWSDynamoDbTableItem_basic (41.73s)
=== RUN   TestAccAWSDynamoDbTableItem_rangeKey
--- PASS: TestAccAWSDynamoDbTableItem_rangeKey (48.55s)
=== RUN   TestAccAWSDynamoDbTableItem_withMultipleItems
--- PASS: TestAccAWSDynamoDbTableItem_withMultipleItems (56.37s)
=== RUN   TestAccAWSDynamoDbTableItem_update
--- PASS: TestAccAWSDynamoDbTableItem_update (79.85s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	226.544s

lorengordon · 2018-02-02T11:23:12Z

@radeksimko any thoughts on a similar data resource? For us we would use it to read values out of dynamodb and feed them to terraform resources.

radeksimko · 2018-02-02T16:57:55Z

@lorengordon Do you mind opening a separate issue for that? We can track the interest and related discussion through it. Thanks.

bflad

Overall nothing blocking here. 😄 I left some notes but nothing really blocking from my perspective.

=== RUN   TestAccAWSDynamoDbTableItem_basic
--- PASS: TestAccAWSDynamoDbTableItem_basic (22.63s)
=== RUN   TestAccAWSDynamoDbTableItem_rangeKey
--- PASS: TestAccAWSDynamoDbTableItem_rangeKey (22.73s)
=== RUN   TestAccAWSDynamoDbTableItem_withMultipleItems
--- PASS: TestAccAWSDynamoDbTableItem_withMultipleItems (23.02s)
=== RUN   TestAccAWSDynamoDbTableItem_update
--- PASS: TestAccAWSDynamoDbTableItem_update (56.47s)

bflad · 2018-02-02T19:29:53Z

aws/resource_aws_dynamodb_table_item.go

+ _, err = retryDynamoDbTableItemOperation(func() (interface{}, error) {
+ return conn.PutItem(&dynamodb.PutItemInput{
+ Item: attributes,
+ // Explode if item exists. We didn't create it.


👍 we can always add an overwrite flag later if necessary

bflad · 2018-02-02T19:30:38Z

aws/resource_aws_dynamodb_table_item.go

+ var err error
+ out, err = f()
+ if err != nil {
+ if isAWSErr(err, dynamodb.ErrCodeLimitExceededException, "Subscriber limit exceeded:") {


Question: Should we move this logic up to dynamodbconn?

bflad · 2018-02-02T19:40:59Z

website/docs/r/dynamodb_table_item.html.markdown

+
+Provides a DynamoDB table item resource
+
+-> **Note:** This resource is not meant to be used for managing _all_ data in your table (unless your table contains just a handful of records), it won't scale.


While I agree the contents of this note are important contextually, we might want to change the wording here a little bit:

Changing _all_ data into large amounts of data since it is not designed to scale

Removing It's not supposed to serve as a backup solution either. and instead just implying this in the next sentence by saying full table **regular backups**.

(note: I agree with the original intent of the sentence) The last sentence is a little awkward since generally in our documentation we don't prescribe solutions for people's application/infrastructure problems in an architecture sense (unless its between competing Terraform resources). DynamoDB might be a good fit for some folks and it could be off-putting to tell them how they should be doing things. I'm not sure if there's a better way to say it, but something to consider.

I removed the last sentence, looking back I agree it did sound a little bit biased.

bflad · 2018-02-02T20:00:45Z

aws/resource_aws_dynamodb_table_item_test.go

+ if err != nil {
+ return err
+ }
+ expectedCount := int64(count)


Nitpick: I think we can rid of this line if we just int64 the type in the signature. 😄

- Use standard retry helpers - Simplify code by extracting code into reusable functions - Add validation - Add missing acceptance tests - Add missing docs

bflad · 2018-02-09T22:28:13Z

This has been released in terraform-provider-aws version 1.9.0. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

ghost · 2020-04-08T17:20:43Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

radeksimko added new-resource Introduces a new resource. service/dynamodb Issues and PRs that pertain to the dynamodb service. labels Feb 2, 2018