Remove underscores from RDS parameter group name validation

[bflad]

This reverts the errant change in #1460. Found via #3395

CreateDBParameterGroup API documentation:

DBParameterGroupName
The name of the DB parameter group.
Constraints:
Must be 1 to 255 letters, numbers, or hyphens.
First character must be a letter
Cannot end with a hyphen or contain two consecutive hyphens

CreateDBClusterParameterGroup API documentation:

DBClusterParameterGroupName
The name of the DB cluster parameter group.
Constraints:
Must match the name of an existing DBClusterParameterGroup.

[radeksimko]

This is really odd.

The only explanation which comes to my mind is that RDS has different validation per region. This has been the case for S3 buckets for a long time.

Can you try creating RDS parameter group in us-west-2 with underscores and verify, please? The docs may not always tell the truth from my past experience, so I'd like us to be sure. 😉

[bflad]

@radeksimko

for REGION in $(aws ec2 describe-regions | jq -r '.Regions[] | .RegionName' | sort); do echo "Testing: $REGION"; aws --region $REGION rds create-db-parameter-group --db-parameter-group-name underscore_db_parameter_group_name --db-parameter-group-family aurora5.6 --description bflad-testing; done
Testing: ap-northeast-1

An error occurred (InvalidParameterValue) when calling the CreateDBParameterGroup operation: The parameter DBParameterGroupName is not a valid identifier. Identifiers must begin with a letter; must contain only ASCII letters, digits, and hyphens; and must not end with a hyphen or contain two consecutive hyphens.
Testing: ap-northeast-2

An error occurred (InvalidParameterValue) when calling the CreateDBParameterGroup operation: The parameter DBParameterGroupName is not a valid identifier. Identifiers must begin with a letter; must contain only ASCII letters, digits, and hyphens; and must not end with a hyphen or contain two consecutive hyphens.
Testing: ap-south-1

An error occurred (InvalidParameterValue) when calling the CreateDBParameterGroup operation: The parameter DBParameterGroupName is not a valid identifier. Identifiers must begin with a letter; must contain only ASCII letters, digits, and hyphens; and must not end with a hyphen or contain two consecutive hyphens.
Testing: ap-southeast-1

An error occurred (InvalidParameterValue) when calling the CreateDBParameterGroup operation: The parameter DBParameterGroupName is not a valid identifier. Identifiers must begin with a letter; must contain only ASCII letters, digits, and hyphens; and must not end with a hyphen or contain two consecutive hyphens.
Testing: ap-southeast-2

An error occurred (InvalidParameterValue) when calling the CreateDBParameterGroup operation: The parameter DBParameterGroupName is not a valid identifier. Identifiers must begin with a letter; must contain only ASCII letters, digits, and hyphens; and must not end with a hyphen or contain two consecutive hyphens.
Testing: ca-central-1

An error occurred (InvalidParameterValue) when calling the CreateDBParameterGroup operation: The parameter DBParameterGroupName is not a valid identifier. Identifiers must begin with a letter; must contain only ASCII letters, digits, and hyphens; and must not end with a hyphen or contain two consecutive hyphens.
Testing: eu-central-1

An error occurred (InvalidParameterValue) when calling the CreateDBParameterGroup operation: The parameter DBParameterGroupName is not a valid identifier. Identifiers must begin with a letter; must contain only ASCII letters, digits, and hyphens; and must not end with a hyphen or contain two consecutive hyphens.
Testing: eu-west-1

An error occurred (InvalidParameterValue) when calling the CreateDBParameterGroup operation: The parameter DBParameterGroupName is not a valid identifier. Identifiers must begin with a letter; must contain only ASCII letters, digits, and hyphens; and must not end with a hyphen or contain two consecutive hyphens.
Testing: eu-west-2

An error occurred (InvalidParameterValue) when calling the CreateDBParameterGroup operation: The parameter DBParameterGroupName is not a valid identifier. Identifiers must begin with a letter; must contain only ASCII letters, digits, and hyphens; and must not end with a hyphen or contain two consecutive hyphens.
Testing: eu-west-3

An error occurred (InvalidParameterValue) when calling the CreateDBParameterGroup operation: The parameter DBParameterGroupName is not a valid identifier. Identifiers must begin with a letter; must contain only ASCII letters, digits, and hyphens; and must not end with a hyphen or contain two consecutive hyphens.
Testing: sa-east-1

An error occurred (InvalidParameterValue) when calling the CreateDBParameterGroup operation: ParameterGroupFamily aurora5.6 is not a valid parameter group family
Testing: us-east-1

An error occurred (InvalidParameterValue) when calling the CreateDBParameterGroup operation: The parameter DBParameterGroupName is not a valid identifier. Identifiers must begin with a letter; must contain only ASCII letters, digits, and hyphens; and must not end with a hyphen or contain two consecutive hyphens.
Testing: us-east-2

An error occurred (InvalidParameterValue) when calling the CreateDBParameterGroup operation: The parameter DBParameterGroupName is not a valid identifier. Identifiers must begin with a letter; must contain only ASCII letters, digits, and hyphens; and must not end with a hyphen or contain two consecutive hyphens.
Testing: us-west-1

An error occurred (InvalidParameterValue) when calling the CreateDBParameterGroup operation: The parameter DBParameterGroupName is not a valid identifier. Identifiers must begin with a letter; must contain only ASCII letters, digits, and hyphens; and must not end with a hyphen or contain two consecutive hyphens.
Testing: us-west-2

An error occurred (InvalidParameterValue) when calling the CreateDBParameterGroup operation: The parameter DBParameterGroupName is not a valid identifier. Identifiers must begin with a letter; must contain only ASCII letters, digits, and hyphens; and must not end with a hyphen or contain two consecutive hyphens.

[radeksimko]

Thanks for the verification @bflad 👍

LGTM.

[bflad]

This has been released in version 1.10.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!