Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update resource_aws_cognito_user_pool_client to bind updates to callback_urls to the correct param #3404

Merged
merged 1 commit into from
Mar 15, 2018

Conversation

cecilia-sanare
Copy link
Contributor

@cecilia-sanare cecilia-sanare commented Feb 15, 2018

Description

Fixes an issue where it was impossible to update a resource_aws_cognito_user_pool_client.

I'm not overly familiar with go, so I don't really know the best way to regression test this.

Related Issues

closes #3384

@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Feb 15, 2018
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Feb 15, 2018
@radeksimko radeksimko added bug Addresses a defect in current functionality. service/cognito labels Feb 16, 2018
@cecilia-sanare
Copy link
Contributor Author

@radeksimko Any updates on this?

@wilsonc101
Copy link

@nick-woodward Did you get any feedback? I've run into this too.

@cecilia-sanare
Copy link
Contributor Author

Nope, not sure what’s blocking this as it’s a fairly small change.

It’s kinda unfortunate as this is a blocker for even using the new functionality.

@bflad bflad self-requested a review March 15, 2018 02:47
@bflad bflad added this to the v1.12.0 milestone Mar 15, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the delay in getting this trivial PR reviewed. 😖 Thanks for this contribution!

Normally we'd be looking for an acceptance test that is broken before the code change (e.g. in this case, taking TestAccAWSCognitoUserPoolClient_allFields and adding a TestStep that updates at least this attribute in a new test configuration) then works afterwards, but in an effort to not break some other PRs behind this one and given its trivial fix nature, I'm going to merge this in as-is.

2 tests passed (all tests)
=== RUN   TestAccAWSCognitoUserPoolClient_allFields
--- PASS: TestAccAWSCognitoUserPoolClient_allFields (8.35s)
=== RUN   TestAccAWSCognitoUserPoolClient_basic
--- PASS: TestAccAWSCognitoUserPoolClient_basic (8.50s)

@bflad bflad merged commit 4efc50b into hashicorp:master Mar 15, 2018
bflad added a commit that referenced this pull request Mar 15, 2018
@bflad
Copy link
Contributor

bflad commented Mar 23, 2018

This has been released in version 1.12.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to update aws_cognito_user_pool_client
4 participants