resource/aws_rds_cluster: Add support for source_region (encrypted cross-region replicas) #3415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
added
enhancement
|
#3413 is approved so this is ready for rebasing 👍 |
…replicated aurora clusters
radeksimko
force-pushed
the
f-rds-cluster-encrypted
branch
from
28b7e7d
to
2717612
Compare
ghost
added
size/L
|
@bflad Rebased. PTAL. |
bflad
approved these changes
Feb 19, 2018
There was a problem hiding this comment.
LGTM! 🚀
=== RUN TestAccAWSRDSCluster_missingUserNameCausesError
--- PASS: TestAccAWSRDSCluster_missingUserNameCausesError (3.28s)
=== RUN TestAccAWSRDSCluster_encrypted
--- PASS: TestAccAWSRDSCluster_encrypted (130.50s)
=== RUN TestAccAWSRDSCluster_iamAuth
--- PASS: TestAccAWSRDSCluster_iamAuth (130.48s)
=== RUN TestAccAWSRDSCluster_basic
--- PASS: TestAccAWSRDSCluster_basic (130.53s)
=== RUN TestAccAWSRDSCluster_importBasic
--- PASS: TestAccAWSRDSCluster_importBasic (131.27s)
=== RUN TestAccAWSRDSCluster_namePrefix
--- PASS: TestAccAWSRDSCluster_namePrefix (133.62s)
=== RUN TestAccAWSRDSCluster_generatedName
--- PASS: TestAccAWSRDSCluster_generatedName (134.89s)
=== RUN TestAccAWSRDSCluster_updateTags
--- PASS: TestAccAWSRDSCluster_updateTags (135.29s)
=== RUN TestAccAWSRDSCluster_updateIamRoles
--- PASS: TestAccAWSRDSCluster_updateIamRoles (135.91s)
=== RUN TestAccAWSRDSCluster_backupsUpdate
--- PASS: TestAccAWSRDSCluster_backupsUpdate (135.90s)
=== RUN TestAccAWSRDSCluster_kmsKey
--- PASS: TestAccAWSRDSCluster_kmsKey (149.55s)
=== RUN TestAccAWSRDSCluster_takeFinalSnapshot
--- PASS: TestAccAWSRDSCluster_takeFinalSnapshot (191.22s)
=== RUN TestAccAWSRDSCluster_EncryptedCrossRegionReplication
--- PASS: TestAccAWSRDSCluster_EncryptedCrossRegionReplication (1538.26s)
|
This has been released in version 1.10.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #3413 (I will rebase this PR after it is merged)
Closes #630
Closes #2111
Closes #2808
I'm building this on top of #2808 as that was closest to merge-able state. I'd normally point out what needs to be changed, but cross-region testing is generally not easy at this point, which motivated me to raise #3413
On that note (and also because both mentioned PRs have been sitting around for a while) I decided to break the etiquette here by re-raising PR with my fixes. I hope it's understandable.
@dselvan Thank you for all you work here, the original commit is preserved so you'll receive the credit you deserve 😉
Test results