Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_instance: Remove extra API call on creation for SGs #3426

Merged
merged 1 commit into from
Feb 20, 2018

Conversation

brettahale
Copy link
Contributor

@brettahale brettahale commented Feb 17, 2018

Stops extra calls to update vpc_security_groups and also a call to modifyNetworkInterface when not needed.

Closes #3399

@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Feb 17, 2018
@radeksimko radeksimko added enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. labels Feb 19, 2018
@radeksimko radeksimko self-assigned this Feb 19, 2018
@radeksimko radeksimko changed the title Update resource_aws_instance.go resource/aws_instance: Remove extra API call on creation for SGs Feb 19, 2018
@radeksimko radeksimko merged commit bd8bab5 into hashicorp:master Feb 20, 2018
@radeksimko
Copy link
Member

Thanks @brettahale for this PR! 👍

@radeksimko radeksimko added this to the v1.10.0 milestone Feb 20, 2018
@brettahale brettahale deleted the vpc-sg-patch branch February 20, 2018 16:35
@brettahale
Copy link
Contributor Author

Woop woop! Np and thank you :)

@bflad
Copy link
Contributor

bflad commented Feb 27, 2018

This has been released in version 1.10.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Superfluous call to ModifyNetworkInterfaceAttribute
3 participants