resource/aws_directory_service_directory: Validate size argument and various code cleanup #3453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…various code cleanup
bflad
added
service/directoryservice
technical-debt
radeksimko
approved these changes
Feb 20, 2018
| } | ||
| if len(settings) > 1 { | ||
| return nil, fmt.Errorf("Only a single vpc_settings block is expected") | ||
| } |
There was a problem hiding this comment.
Nitpick: We could replace this with MaxItems: 1 in the schema, IMO.
There was a problem hiding this comment.
Updated and testing now 👍
| s := settings[0].(map[string]interface{}) | ||
| if len(settings) > 1 { | ||
| return nil, fmt.Errorf("Only a single connect_settings block is expected") | ||
| } |
There was a problem hiding this comment.
Likewise - we can replace this with MaxItems: 1
There was a problem hiding this comment.
Updated and testing now 👍
…_settings and vpc_settings attributes
|
LGTM after switching to |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed while working with the last PR.