resource/ebs_snapshot: fix crash in case of manual deletion

[loivis]

Fix #3460

Also enhance error checking in case of any other error.

[bflad]

The error code change LGTM according to the EC2 API documentation.

Can you add an acceptance test that fails then passes to prevent this in the future and verify your fix? e.g.

{
  Config: //basic
}
{
  PreConfig: func() {
    // SDK call to DeleteSnapshot
  },
  Config: // basic
}

We may also want to have an additional check to remove the ID from the state and return nil if len(res.Snapshots) == 0

[radeksimko]

Nitpick: We tend to prefix such messages with [WARN] so it's easy to find them in the log.

[loivis]

of coz

[loivis]

⎇  echo > aws/debug.log ; and make testacc TEST=./aws TESTARGS='-run=TestAccAWSEBSSnapshot_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSEBSSnapshot_ -timeout 120m
=== RUN   TestAccAWSEBSSnapshot_basic
--- PASS: TestAccAWSEBSSnapshot_basic (141.96s)
=== RUN   TestAccAWSEBSSnapshot_withDescription
--- PASS: TestAccAWSEBSSnapshot_withDescription (47.26s)
=== RUN   TestAccAWSEBSSnapshot_withKms
--- PASS: TestAccAWSEBSSnapshot_withKms (59.23s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	248.498s

[loivis]

anything else to change before merge?

[bflad]

LGTM! Thanks so much! 🚀

=== RUN   TestAccAWSEBSSnapshot_withDescription
--- PASS: TestAccAWSEBSSnapshot_withDescription (33.29s)
=== RUN   TestAccAWSEBSSnapshot_withKms
--- PASS: TestAccAWSEBSSnapshot_withKms (53.12s)
=== RUN   TestAccAWSEBSSnapshot_basic
--- PASS: TestAccAWSEBSSnapshot_basic (84.94s)

[bflad]

Minor nitpick: Not all regions have/will have AZ a available but this is certainly an improvement (data.aws_availability_zones.current[0].id is safer)

[bflad]

This has been released in version 1.11.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!