Bug fix for issue 3268

[wattdave]

#3268

This seems to arise via explicit use of the 'state' variable.

[bflad]

Hi @wattdave, thanks for this fix! While the fix looks correct, would you have time to create a proper acceptance test for updating the state rather than modifying these two existing test configurations? If not, that's okay too. 👍

Basically, you should be able to copy one of the existing acceptance tests like TestAccAWSBatchComputeEnvironment_updateInstanceType and create a new configuration that changes only the state. We can explicitly look for the attribute to be set correctly in the state with something like resource.TestCheckResourceAttr("aws_batch_compute_environment.ec2", "state", "DISABLED"),

[wattdave]

@bflad Here you go; it includes a test that illustrates the explicit overwrite of the service role that causes grief when trying to change an existing compute environment.

Actually on re-reading your suggestion I realize I didn't do what you asked. Sec...

[wattdave]

@bflad This seems gtg now - are these tests what you want?

[bflad]

The acceptance test is failing currently, but I'll fix it on merge.

=== RUN   TestAccAWSBatchComputeEnvironment_updateState
--- FAIL: TestAccAWSBatchComputeEnvironment_updateState (96.32s)
    testing.go:513: Step 1 error: Check failed: Check 3/3 error: aws_batch_compute_environment.ec2: Attribute 'service_role' expected "tf_acc_test_batch_svc_role_7867757812779672119", got "arn:aws:iam::*******:role/tf_acc_test_batch_svc_role_7867757812779672119"
FAIL

[bflad]

Merged into master and will release with v1.11.0 of the AWS provider. Thanks so much!

[bflad]

This has been released in version 1.11.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!