Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for timeouts on aws_eip resource #3769

Merged
merged 1 commit into from
Mar 14, 2018
Merged

Add support for timeouts on aws_eip resource #3769

merged 1 commit into from
Mar 14, 2018

Conversation

ctso
Copy link
Contributor

@ctso ctso commented Mar 13, 2018

Adds the ability to override timeouts for the aws_eip resource.

Would be nice to have #3586 along with this change, as we're running into something similar as reported in #3128 but with EIPs instead of security groups.

Open to suggestions on the timeouts here.

@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label Mar 13, 2018
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. labels Mar 14, 2018
@bflad bflad self-requested a review March 14, 2018 14:28
@bflad bflad added this to the v1.12.0 milestone Mar 14, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks! 🚀

14 tests passed (all tests)
=== RUN   TestAccAWSEIP_classic_disassociate
=== RUN   TestAccAWSEIP_disappears
--- PASS: TestAccAWSEIP_disappears (14.59s)
=== RUN   TestAccAWSEIP_basic
--- PASS: TestAccAWSEIP_basic (17.49s)
=== RUN   TestAccAWSEIP_tags
--- PASS: TestAccAWSEIP_tags (25.75s)
=== RUN   TestAccAWSEIP_importVpc
--- PASS: TestAccAWSEIP_importVpc (36.86s)
=== RUN   TestAccAWSEIP_network_interface
--- PASS: TestAccAWSEIP_network_interface (43.79s)
=== RUN   TestAccAWSEIP_twoEIPsOneNetworkInterface
--- PASS: TestAccAWSEIP_twoEIPsOneNetworkInterface (45.51s)
=== RUN   TestAccAWSEIPAssociation_ec2Classic
--- PASS: TestAccAWSEIPAssociation_ec2Classic (96.94s)
=== RUN   TestAccAWSEIPAssociation_disappears
--- PASS: TestAccAWSEIPAssociation_disappears (131.31s)
=== RUN   TestAccAWSEIPAssociation_basic
--- PASS: TestAccAWSEIPAssociation_basic (171.37s)
=== RUN   TestAccAWSEIPAssociation_spotInstance
--- PASS: TestAccAWSEIPAssociation_spotInstance (182.10s)
=== RUN   TestAccAWSEIP_instance
--- PASS: TestAccAWSEIP_instance (213.75s)
=== RUN   TestAccAWSEIP_associated_user_private_ip
--- PASS: TestAccAWSEIP_associated_user_private_ip (240.76s)
=== RUN   TestAccAWSEIP_importEc2Classic
--- PASS: TestAccAWSEIP_importEc2Classic (248.48s)
=== RUN   TestAccAWSEIPAssociate_not_associated
--- PASS: TestAccAWSEIPAssociate_not_associated (273.82s)

@bflad bflad merged commit 4df232f into hashicorp:master Mar 14, 2018
bflad added a commit that referenced this pull request Mar 14, 2018
@ctso ctso deleted the eip-timeout branch March 14, 2018 17:15
@bflad
Copy link
Contributor

bflad commented Mar 23, 2018

This has been released in version 1.12.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants