Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_sqs_queue: Remove explicit IsGovCloud() check #3794

Merged
merged 1 commit into from
Mar 15, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Mar 15, 2018

This is a reimplementation of #3376 that future-proofs the resource as well as supports the ListQueueTags API call being missing from other non-standard AWS implementations (e.g. localstack).

Closes #3727

Passes same way as before in us-gov-west-1 (resource does not just error out, eventual consistency hasn't been fixed yet):

make testacc TEST=./aws TESTARGS='-run=TestAccAWSSQSQueue_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSSQSQueue_basic -timeout 120m
=== RUN   TestAccAWSSQSQueue_basic
--- FAIL: TestAccAWSSQSQueue_basic (29.54s)
	testing.go:513: Step 1 error: After applying this step, the plan was not empty:

		DIFF:

		UPDATE: aws_sqs_queue.queue
		  delay_seconds:              "0" => "90"
		  max_message_size:           "262144" => "2048"
		  message_retention_seconds:  "345600" => "86400"
		  receive_wait_time_seconds:  "0" => "10"
		  visibility_timeout_seconds: "30" => "60"

Standard partition testing passes:

make testacc TEST=./aws TESTARGS='-run=TestAccAWSSQSQueue'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSSQSQueue -timeout 120m
=== RUN   TestAccAWSSQSQueue_importBasic
--- PASS: TestAccAWSSQSQueue_importBasic (13.51s)
=== RUN   TestAccAWSSQSQueue_importFifo
--- PASS: TestAccAWSSQSQueue_importFifo (12.79s)
=== RUN   TestAccAWSSQSQueue_importEncryption
--- PASS: TestAccAWSSQSQueue_importEncryption (13.41s)
=== RUN   TestAccAWSSQSQueuePolicy_basic
--- PASS: TestAccAWSSQSQueuePolicy_basic (13.47s)
=== RUN   TestAccAWSSQSQueuePolicy_import
--- PASS: TestAccAWSSQSQueuePolicy_import (15.07s)
=== RUN   TestAccAWSSQSQueue_basic
--- PASS: TestAccAWSSQSQueue_basic (27.46s)
=== RUN   TestAccAWSSQSQueue_tags
--- PASS: TestAccAWSSQSQueue_tags (29.25s)
=== RUN   TestAccAWSSQSQueue_namePrefix
--- PASS: TestAccAWSSQSQueue_namePrefix (11.45s)
=== RUN   TestAccAWSSQSQueue_policy
--- PASS: TestAccAWSSQSQueue_policy (14.97s)
=== RUN   TestAccAWSSQSQueue_queueDeletedRecently
--- PASS: TestAccAWSSQSQueue_queueDeletedRecently (82.60s)
=== RUN   TestAccAWSSQSQueue_redrivePolicy
--- PASS: TestAccAWSSQSQueue_redrivePolicy (15.47s)
=== RUN   TestAccAWSSQSQueue_Policybasic
--- PASS: TestAccAWSSQSQueue_Policybasic (26.92s)
=== RUN   TestAccAWSSQSQueue_FIFO
--- PASS: TestAccAWSSQSQueue_FIFO (13.05s)
=== RUN   TestAccAWSSQSQueue_FIFOExpectNameError
--- PASS: TestAccAWSSQSQueue_FIFOExpectNameError (2.29s)
=== RUN   TestAccAWSSQSQueue_FIFOWithContentBasedDeduplication
--- PASS: TestAccAWSSQSQueue_FIFOWithContentBasedDeduplication (10.12s)
=== RUN   TestAccAWSSQSQueue_ExpectContentBasedDeduplicationError
--- PASS: TestAccAWSSQSQueue_ExpectContentBasedDeduplicationError (3.63s)
=== RUN   TestAccAWSSQSQueue_Encryption
--- PASS: TestAccAWSSQSQueue_Encryption (10.63s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	316.103s

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/sqs Issues and PRs that pertain to the sqs service. partition/aws-us-gov Pertains to the aws-us-gov partition. labels Mar 15, 2018
@bflad bflad added this to the v1.12.0 milestone Mar 15, 2018
@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label Mar 15, 2018
@bflad bflad merged commit 9159c92 into master Mar 15, 2018
@bflad bflad deleted the f-aws_sqs_queue-remove-isgovcloud-check branch March 15, 2018 17:48
bflad added a commit that referenced this pull request Mar 15, 2018
@bflad
Copy link
Contributor Author

bflad commented Mar 23, 2018

This has been released in version 1.12.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. partition/aws-us-gov Pertains to the aws-us-gov partition. service/sqs Issues and PRs that pertain to the sqs service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants