Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_api_gateway_client_certificate: Export date fields correctly #3805

Merged
merged 1 commit into from
Mar 17, 2018

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Mar 16, 2018

This was uncovered in our recent test run with TF_SCHEMA_PANIC_ON_ERROR=1:

=== RUN   TestAccAWSAPIGatewayClientCertificate_basic

------- Stderr: -------
panic: created_date: '' expected type 'string', got unconvertible type '*time.Time'

goroutine 113 [running]:
github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform/helper/schema.(*ResourceData).Set(0xc4202a8070, 0x2f8ec87, 0xc, 0x2f4dd40, 0xc420544960, 0x0, 0x0)
    /opt/teamcity-agent/work/6025502d125bbe5e/src/github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform/helper/schema/resource_data.go:191 +0x237
github.com/terraform-providers/terraform-provider-aws/aws.resourceAwsApiGatewayClientCertificateRead(0xc4202a8070, 0x2b5b4c0, 0xc420286500, 0x0, 0x0)
    /opt/teamcity-agent/work/6025502d125bbe5e/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_api_gateway_client_certificate.go:80 +0x3a5
...
=== RUN   TestAccAWSAPIGatewayClientCertificate_importBasic

------- Stderr: -------
panic: created_date: '' expected type 'string', got unconvertible type '*time.Time'

goroutine 152 [running]:
github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform/helper/schema.(*ResourceData).Set(0xc42010f490, 0x2f8ec87, 0xc, 0x2f4dd40, 0xc420596200, 0x0, 0x0)
    /opt/teamcity-agent/work/6025502d125bbe5e/src/github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform/helper/schema/resource_data.go:191 +0x237
github.com/terraform-providers/terraform-provider-aws/aws.resourceAwsApiGatewayClientCertificateRead(0xc42010f490, 0x2b5b4c0, 0xc420279900, 0x0, 0x0)
    /opt/teamcity-agent/work/6025502d125bbe5e/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_api_gateway_client_certificate.go:80 +0x3a5

Test results

TF_ACC=1 go test ./aws -v -run=TestAccAWSAPIGatewayClientCertificate_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayClientCertificate_basic
--- PASS: TestAccAWSAPIGatewayClientCertificate_basic (49.03s)
=== RUN   TestAccAWSAPIGatewayClientCertificate_importBasic
--- PASS: TestAccAWSAPIGatewayClientCertificate_importBasic (32.10s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	81.182s

@radeksimko radeksimko added service/apigateway Issues and PRs that pertain to the apigateway service. technical-debt Addresses areas of the codebase that need refactoring or redesign. labels Mar 16, 2018
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Mar 16, 2018
@bflad bflad added this to the v1.12.0 milestone Mar 17, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

2 tests passed (all tests)
=== RUN   TestAccAWSAPIGatewayClientCertificate_importBasic
--- PASS: TestAccAWSAPIGatewayClientCertificate_importBasic (9.11s)
=== RUN   TestAccAWSAPIGatewayClientCertificate_basic
--- PASS: TestAccAWSAPIGatewayClientCertificate_basic (11.84s)

@bflad bflad merged commit 49299f5 into master Mar 17, 2018
@bflad bflad deleted the b-apig-cc-time branch March 17, 2018 17:51
@bflad
Copy link
Contributor

bflad commented Mar 23, 2018

This has been released in version 1.12.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/apigateway Issues and PRs that pertain to the apigateway service. size/XS Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants