Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_ssm_document: Add document_format argument #3814

Merged
merged 1 commit into from
Mar 20, 2018
Merged

resource/aws_ssm_document: Add document_format argument #3814

merged 1 commit into from
Mar 20, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Mar 16, 2018

Adds support for YAML!

Closes #3810

Tests

6 tests passed (all tests)
=== RUN   TestAccAWSSSMDocument_basic
--- PASS: TestAccAWSSSMDocument_basic (10.32s)
=== RUN   TestAccAWSSSMDocument_params
--- PASS: TestAccAWSSSMDocument_params (10.73s)
=== RUN   TestAccAWSSSMDocument_update
--- PASS: TestAccAWSSSMDocument_update (15.99s)
=== RUN   TestAccAWSSSMDocument_permission
--- PASS: TestAccAWSSSMDocument_permission (17.39s)
=== RUN   TestAccAWSSSMDocument_DocumentFormat_YAML
--- PASS: TestAccAWSSSMDocument_DocumentFormat_YAML (20.94s)
=== RUN   TestAccAWSSSMDocument_automation
--- PASS: TestAccAWSSSMDocument_automation (31.70s)

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/ssm Issues and PRs that pertain to the ssm service. labels Mar 16, 2018
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Mar 16, 2018
@bflad bflad mentioned this pull request Mar 16, 2018
Closed
radeksimko
radeksimko approved these changes Mar 20, 2018
View reviewed changes
website/docs/r/ssm_document.html.markdown
* `document_type` - (Required) The type of the document. Valid document types include: `Command`, `Policy` and `Automation`
* `permissions` - (Optional) Additional Permissions to attach to the document. See [Permissions](#permissions) below for details.

## Attributes Reference

The following attributes are exported:
The following additional attributes are exported:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 💯

@bflad bflad added this to the v1.12.0 milestone Mar 20, 2018
@bflad bflad merged commit 9713813 into master Mar 20, 2018
@bflad bflad deleted the f-aws_ssm_document-document_format branch March 20, 2018 12:42
bflad added a commit that referenced this pull request Mar 20, 2018
@bflad
Update CHANGELOG for #3814
f49a1b8
@bflad
Copy link
Contributor Author

bflad commented Mar 23, 2018

This has been released in version 1.12.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ssm Issues and PRs that pertain to the ssm service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.12.0
Development

Successfully merging this pull request may close these issues.

Add support for YAML for defining SSM documents (aws_ssm_document)
2 participants
@bflad @radeksimko