aws_api_gateway_rest_api: Add execute_arn computed attribute #3968
Conversation
radeksimko
added
service/apigateway
ghost
added
size/M
…ution_arn` attribute
mewa
changed the title
| restApiId := d.Id() | ||
| region := meta.(*AWSClient).region | ||
| accountId := meta.(*AWSClient).accountid | ||
| arn, err := buildApiGatewayExecutionARN(restApiId, region, accountId) |
There was a problem hiding this comment.
This function no longer exists as we have moved to prefer using the SDK arn package. Can you please build the ARN like the following (modifying as appropriate):
executionArn := arn.ARN{
Partition: meta.(*AWSClient).partition,
Service: "execute-api",
Region: meta.(*AWSClient).region,
AccountID: meta.(*AWSClient).accountid,
Resource: d.Id(),
}.String()
d.Set("execution_arn", executionArn)| ```hcl | ||
| resource "aws_api_gateway_rest_api" "MyDemoAPI" { | ||
| name = "MyDemoAPI" | ||
| description = "This is my API for demonstration purposes" | ||
| } | ||
| ``` | ||
|
|
||
| ### Using REST API execution_arn to specify Lambda permissions |
There was a problem hiding this comment.
Can you please move this example to the aws_lambda_permission resource documentation instead?
bflad
added
the
waiting-response
…tribute to `aws_lambda_permission` docs
|
Hi @bflad, thank you for your response (and sorry for replying late). I have applied your suggestions and merged changes from master, so hopefully the PR should be good to go. |
bflad
removed
the
waiting-response
There was a problem hiding this comment.
Thanks so much @mewa, looks great! 🚀
3 tests passed (all tests)
=== RUN TestAccAWSAPIGatewayRestApi_openapi
--- PASS: TestAccAWSAPIGatewayRestApi_openapi (12.58s)
=== RUN TestAccAWSAPIGatewayRestApi_basic
--- PASS: TestAccAWSAPIGatewayRestApi_basic (43.96s)
=== RUN TestAccAWSAPIGatewayRestApi_policy
--- PASS: TestAccAWSAPIGatewayRestApi_policy (118.16s)
|
This has been released in version 1.19.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Added execute_arn attribute as described in #3967