Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: aws_glue_connection #4016

Merged
merged 1 commit into from
Apr 13, 2018
Merged

New Resource: aws_glue_connection #4016

merged 1 commit into from
Apr 13, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Apr 3, 2018

Closes #3874

make testacc TEST=./aws TESTARGS='-run=TestAccAWSGlueConnection'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSGlueConnection -timeout 120m
=== RUN   TestAccAWSGlueConnection_Basic
--- PASS: TestAccAWSGlueConnection_Basic (12.92s)
=== RUN   TestAccAWSGlueConnection_Description
--- PASS: TestAccAWSGlueConnection_Description (19.69s)
=== RUN   TestAccAWSGlueConnection_MatchCriteria
--- PASS: TestAccAWSGlueConnection_MatchCriteria (29.49s)
=== RUN   TestAccAWSGlueConnection_PhysicalConnectionRequirements
--- PASS: TestAccAWSGlueConnection_PhysicalConnectionRequirements (642.15s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	704.298s

@bflad bflad added new-resource Introduces a new resource. service/glue Issues and PRs that pertain to the glue service. labels Apr 3, 2018
@bflad bflad added this to the v1.14.0 milestone Apr 3, 2018
@ghost ghost added the size/XL Managed by automation to categorize the size of a PR. label Apr 3, 2018
@ghost ghost added the size/XL Managed by automation to categorize the size of a PR. label Apr 3, 2018
@bflad bflad requested a review from a team April 3, 2018 02:31
@bflad bflad modified the milestones: v1.14.0, v1.15.0 Apr 6, 2018
Copy link
Contributor

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@bflad bflad merged commit 8f7bc21 into master Apr 13, 2018
@bflad bflad deleted the f-aws_glue_connection branch April 13, 2018 19:53
bflad added a commit that referenced this pull request Apr 13, 2018
@bflad
Copy link
Contributor Author

bflad commented Apr 18, 2018

This has been released in version 1.15.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@glindholm
Copy link

glindholm commented May 15, 2018

Hi Brian, I'm trying to use the aws_glue_connection resource and having a problem.
I'm creating a Connection to a data source in private VPC subnet, specifically to RDS Aurora.
The Connection gets created but the AvailabiltyZone is not being set. I see that the AWS api docs state the AvailablityZone is not required (and deprecated and had not effect), however, if AvailabilityZone is not set then Test Connection or a Glue Job that tries to use the connection fails with Exception CONNECTION_LIST_CONNECTION_WITH_AZ_NULL.
I believe the AWS api docs is wrong, and have reported this to AWS.
When your Connection is into a private subnet then the AZ and subnet must be specified.
When you create a connection from the console it always sets the AvailabiltyZone, you can see this from the CLI (aws glue get-connections).
If I modify the connection Terraform creates and add the AvailabilityZone then the connection works correctly.

@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-resource Introduces a new resource. service/glue Issues and PRs that pertain to the glue service. size/XL Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Resource for managing AWS Glue Connections
3 participants