New Resource: aws_glue_job

[bflad]

Closes #3877

make testacc TEST=./aws TESTARGS='-run=TestAccAWSGlueJob'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSGlueJob -timeout 120m
=== RUN   TestAccAWSGlueJob_Basic
--- PASS: TestAccAWSGlueJob_Basic (15.46s)
=== RUN   TestAccAWSGlueJob_AllocatedCapacity
--- PASS: TestAccAWSGlueJob_AllocatedCapacity (21.94s)
=== RUN   TestAccAWSGlueJob_Command
--- PASS: TestAccAWSGlueJob_Command (22.96s)
=== RUN   TestAccAWSGlueJob_DefaultArguments
--- PASS: TestAccAWSGlueJob_DefaultArguments (22.08s)
=== RUN   TestAccAWSGlueJob_Description
--- PASS: TestAccAWSGlueJob_Description (20.97s)
=== RUN   TestAccAWSGlueJob_ExecutionProperty
--- PASS: TestAccAWSGlueJob_ExecutionProperty (21.68s)
=== RUN   TestAccAWSGlueJob_MaxRetries
--- PASS: TestAccAWSGlueJob_MaxRetries (23.47s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	148.608s

[katbyte]

LGTM aside from one minor comment that can probably be ignored :)

[katbyte]

Is there a reason to have this in an execution_property block property instead of having max_concurrent_runs at the top level like max_retries is?

Just to match the API? A potential for more options in execution_property?

[bflad]

Just to match the API 😄 We've gotten bitten in the past by colliding attribute names. https://docs.aws.amazon.com/sdk-for-go/api/service/glue/#CreateJobInput

[katbyte]

Valid! Good thing to keep in mind then.

[cemo]

Thanks @bflad. What will be next target? Any chance for #3875 ? :)

[bflad]

This has been released in version 1.15.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[hugoalmeida264]

Hi guys, thank you so much to all of you for your hard work on the glue job we are using it across our datalakes and we love it!

One question, there is no reference to the SecurityConfiguration option on the provider and I was wondering if this is going to be left out of scope.

This is important for the scenario where the bucket policy enforces encryption and the glue job tries to write unencrypted, it will fail.

Thank you! @bflad

[bflad]

Hi @hugoalmeida17, please create a new Feature Request issue, thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!