resource/aws_vpc_peering_connection: Allow active pending state during deletion

[bflad]

Most likely caused by eventual consistency.

=== RUN   TestAccDataSourceAwsVpcPeeringConnection_basic
--- FAIL: TestAccDataSourceAwsVpcPeeringConnection_basic (1239.22s)
    testing.go:573: Error destroying resource! WARNING: Dangling resources
        may exist. The full state and error is shown below.
        
        Error: Error applying: 1 error(s) occurred:
        
        * aws_vpc_peering_connection.test (destroy): 1 error(s) occurred:
        
        * aws_vpc_peering_connection.test: Error waiting for VPC Peering Connection (pcx-1574737c) to be deleted: unexpected state 'active', wanted target 'rejected, deleted'. last error: %!s(<nil>)

=== RUN   TestAccAWSVPCPeeringConnection_tags
--- FAIL: TestAccAWSVPCPeeringConnection_tags (179.23s)
    testing.go:579: Error destroying resource! WARNING: Dangling resources
        may exist. The full state and error is shown below.
        
        Error: Error applying: 1 error(s) occurred:
        
        * aws_vpc_peering_connection.foo (destroy): 1 error(s) occurred:
        
        * aws_vpc_peering_connection.foo: Error waiting for VPC Peering Connection (pcx-8c7c6ae5) to be deleted: unexpected state 'active', wanted target 'rejected, deleted'. last error: %!s(<nil>)

10 tests passed (all tests)
=== RUN   TestAccAWSVPCPeeringConnection_plan
--- PASS: TestAccAWSVPCPeeringConnection_plan (71.98s)
=== RUN   TestAccAWSVPCPeeringConnection_failedState
--- PASS: TestAccAWSVPCPeeringConnection_failedState (82.19s)
=== RUN   TestAccAWSVPCPeeringConnection_peerRegionAndAutoAccept
--- PASS: TestAccAWSVPCPeeringConnection_peerRegionAndAutoAccept (88.49s)
=== RUN   TestAccAWSVPCPeeringConnectionAccepter_differentRegion
--- PASS: TestAccAWSVPCPeeringConnectionAccepter_differentRegion (94.51s)
=== RUN   TestAccAWSVPCPeeringConnectionAccepter_sameRegion
--- PASS: TestAccAWSVPCPeeringConnectionAccepter_sameRegion (122.65s)
=== RUN   TestAccAWSVPCPeeringConnection_tags
--- PASS: TestAccAWSVPCPeeringConnection_tags (126.29s)
=== RUN   TestAccAWSVPCPeeringConnection_options
--- PASS: TestAccAWSVPCPeeringConnection_options (131.02s)
=== RUN   TestAccAWSVPCPeeringConnection_importBasic
--- PASS: TestAccAWSVPCPeeringConnection_importBasic (142.79s)
=== RUN   TestAccAWSVPCPeeringConnection_region
--- PASS: TestAccAWSVPCPeeringConnection_region (143.10s)
=== RUN   TestAccAWSVPCPeeringConnection_basic
--- PASS: TestAccAWSVPCPeeringConnection_basic (177.32s)

[katbyte]

LGTM 👍

[bflad]

This has been released in version 1.14.1 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!