resource/aws_db_event_subscription: Fix tag ARN handling

[bflad]

Additional updates:

• Add arn attribute
• Support configurable timeouts
• Use isAWSErr()
• Skip returning an error when deleting a non-existent subscription

The regression occurred during #4053, which was merged in for release in v1.14.0 of the AWS provider.

Fixes #4138 and the following testing:

=== RUN   TestAccAWSDBEventSubscription_basicUpdate
--- FAIL: TestAccAWSDBEventSubscription_basicUpdate (168.94s)
    testing.go:518: Step 0 error: Check failed: Check 5/5 error: aws_db_event_subscription.bar: Attribute 'tags.Name' not found

=== RUN   TestAccAWSDBEventSubscription_categoryUpdate
--- FAIL: TestAccAWSDBEventSubscription_categoryUpdate (617.09s)
    testing.go:518: Step 0 error: After applying this step, the plan was not empty:
        
        DIFF:
        
        UPDATE: aws_db_event_subscription.bar
          tags.%:    "0" => "1"
          tags.Name: "" => "name"

=== RUN   TestAccAWSDBEventSubscription_importBasic
--- FAIL: TestAccAWSDBEventSubscription_importBasic (769.86s)
    testing.go:518: Step 0 error: After applying this step, the plan was not empty:
        
        DIFF:
        
        UPDATE: aws_db_event_subscription.bar
          tags.%:    "0" => "1"
          tags.Name: "" => "name"

=== RUN   TestAccAWSDBEventSubscription_withSourceIds
--- FAIL: TestAccAWSDBEventSubscription_withSourceIds (166.35s)
    testing.go:518: Step 0 error: After applying this step, the plan was not empty:
        
        DIFF:
        
        UPDATE: aws_db_event_subscription.bar
          tags.%:    "0" => "1"
          tags.Name: "" => "name"

4 tests passed (all tests)
=== RUN   TestAccAWSDBEventSubscription_importBasic
--- PASS: TestAccAWSDBEventSubscription_importBasic (750.01s)
=== RUN   TestAccAWSDBEventSubscription_withSourceIds
--- PASS: TestAccAWSDBEventSubscription_withSourceIds (755.63s)
=== RUN   TestAccAWSDBEventSubscription_basicUpdate
--- PASS: TestAccAWSDBEventSubscription_basicUpdate (1235.63s)
=== RUN   TestAccAWSDBEventSubscription_categoryUpdate
--- PASS: TestAccAWSDBEventSubscription_categoryUpdate (1235.67s)

[catsby]

👍 1 nitpick, leave if you'd like

[catsby]

nit: d.SetId should handle pointers fine (unlike d.Set, IIRC)

[bflad]

I'd like to do some out of scope testing, but at first look d.SetId() does not have the same nil value reflection as d.Set():

https://github.com/hashicorp/terraform/blob/2dc7241df0245b2be005946b4bc903dfab496c71/helper/schema/resource_data.go#L246-L249

https://github.com/hashicorp/terraform/blob/2dc7241df0245b2be005946b4bc903dfab496c71/helper/schema/resource_data.go#L171-L187

InstanceState.ID is string so it'd likely cause an interface panic still if I'm understanding the code correctly.

https://github.com/hashicorp/terraform/blob/2dc7241df0245b2be005946b4bc903dfab496c71/terraform/state.go#L1614

[bflad]

This has been released in version 1.14.1 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!