Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_iam_role: Suppress NoSuchEntity errors while detaching policies from role #4209

Merged

Conversation

spirius
Copy link
Contributor

@spirius spirius commented Apr 14, 2018

aws_iam_role with force_detach_policies = true sometimes gets outdated list of attached policies from AWS. This happens when terraform is removing aws_iam_role right after removing aws_iam_role_policy_attachment resources.

@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label Apr 14, 2018
@spirius spirius force-pushed the feature/iam-role-suppress-detach-error branch from 2bb64f6 to 9db8731 Compare April 14, 2018 18:05
@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label Apr 14, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks @spirius! 🚀

@bflad bflad added bug Addresses a defect in current functionality. service/iam Issues and PRs that pertain to the iam service. labels Apr 17, 2018
@bflad bflad added this to the v1.15.0 milestone Apr 17, 2018
@bflad bflad merged commit 983d10e into hashicorp:master Apr 17, 2018
bflad added a commit that referenced this pull request Apr 17, 2018
@spirius spirius deleted the feature/iam-role-suppress-detach-error branch April 17, 2018 20:52
@bflad
Copy link
Contributor

bflad commented Apr 18, 2018

This has been released in version 1.15.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/iam Issues and PRs that pertain to the iam service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants