Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data-source/cognito_user_pools: add attribute of arns #4256

Merged
merged 1 commit into from
Apr 20, 2018
Merged

data-source/cognito_user_pools: add attribute of arns #4256

merged 1 commit into from
Apr 20, 2018

Conversation

loivis
Copy link
Contributor

@loivis loivis commented Apr 18, 2018

This should have been in the first implement with #4212. I missed to check even though an example was provided to serve as api gateway authorizer. As it's not returned directly from aws api, arn is populated from id.

@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label Apr 18, 2018
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/cognito labels Apr 20, 2018
bflad
bflad approved these changes Apr 20, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks! 🚀

1 test passed (all tests)
=== RUN   TestAccDataSourceAwsCognitoUserPools_basic
--- PASS: TestAccDataSourceAwsCognitoUserPools_basic (8.10s)

@bflad bflad added this to the v1.16.0 milestone Apr 20, 2018
@bflad bflad merged commit b4bb3f8 into hashicorp:master Apr 20, 2018
bflad added a commit that referenced this pull request Apr 20, 2018
@bflad
Update CHANGELOG for #4256
3300d09
@loivis loivis deleted the data-source-cognito-user-pools branch April 23, 2018 13:26
@bflad
Copy link
Contributor

bflad commented Apr 25, 2018

This has been released in version 1.16.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@loivis @bflad