Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resources and Data Sources: aws_secretsmanager_secret* #4272

Merged
merged 3 commits into from
Apr 24, 2018
Merged

New Resources and Data Sources: aws_secretsmanager_secret* #4272

merged 3 commits into from
Apr 24, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Apr 19, 2018

Closes #4060

New Resources:

  • aws_secretsmanager_secret
  • aws_secretsmanager_secretversion

New Data Sources:

  • aws_secretsmanager_secret
  • aws_secretsmanager_secretversion
make testacc TEST=./aws TESTARGS='-run=AwsSecretsManager'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=AwsSecretsManager -timeout 120m
=== RUN   TestAccDataSourceAwsSecretsManagerSecret_Basic
--- PASS: TestAccDataSourceAwsSecretsManagerSecret_Basic (5.54s)
=== RUN   TestAccDataSourceAwsSecretsManagerSecret_ARN
--- PASS: TestAccDataSourceAwsSecretsManagerSecret_ARN (11.24s)
=== RUN   TestAccDataSourceAwsSecretsManagerSecret_Name
--- PASS: TestAccDataSourceAwsSecretsManagerSecret_Name (11.82s)
=== RUN   TestAccDataSourceAwsSecretsManagerSecretVersion_Basic
--- PASS: TestAccDataSourceAwsSecretsManagerSecretVersion_Basic (14.41s)
=== RUN   TestAccDataSourceAwsSecretsManagerSecretVersion_VersionID
--- PASS: TestAccDataSourceAwsSecretsManagerSecretVersion_VersionID (14.18s)
=== RUN   TestAccDataSourceAwsSecretsManagerSecretVersion_VersionStage
--- PASS: TestAccDataSourceAwsSecretsManagerSecretVersion_VersionStage (13.31s)
=== RUN   TestAccAwsSecretsManagerSecret_Basic
--- PASS: TestAccAwsSecretsManagerSecret_Basic (12.01s)
=== RUN   TestAccAwsSecretsManagerSecret_Description
--- PASS: TestAccAwsSecretsManagerSecret_Description (18.59s)
=== RUN   TestAccAwsSecretsManagerSecret_KmsKeyID
--- PASS: TestAccAwsSecretsManagerSecret_KmsKeyID (52.88s)
=== RUN   TestAccAwsSecretsManagerSecret_RotationLambdaARN
--- PASS: TestAccAwsSecretsManagerSecret_RotationLambdaARN (47.56s)
=== RUN   TestAccAwsSecretsManagerSecret_RotationRules
--- PASS: TestAccAwsSecretsManagerSecret_RotationRules (46.72s)
=== RUN   TestAccAwsSecretsManagerSecret_Tags
--- PASS: TestAccAwsSecretsManagerSecret_Tags (34.72s)
=== RUN   TestAccAwsSecretsManagerSecretVersion_Basic
--- PASS: TestAccAwsSecretsManagerSecretVersion_Basic (11.76s)
=== RUN   TestAccAwsSecretsManagerSecretVersion_VersionStages
--- PASS: TestAccAwsSecretsManagerSecretVersion_VersionStages (31.19s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	326.005s

@bflad bflad added new-resource Introduces a new resource. new-data-source Introduces a new data source. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. labels Apr 19, 2018
@bflad bflad requested a review from a team April 19, 2018 20:48
@ghost ghost added the size/XXL Managed by automation to categorize the size of a PR. label Apr 19, 2018
This was referenced Apr 19, 2018
Closed
Closed
paultyng
paultyng approved these changes Apr 24, 2018
View reviewed changes
Copy link
Contributor

@paultyng paultyng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mostly, but some minor comments

aws/resource_aws_secretsmanager_secret.go Outdated
"time"

"github.com/hashicorp/terraform/helper/resource"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

goimports strikes again! Not sure why it thinks it needs to do this sometimes. I'll get it updated

aws/resource_aws_secretsmanager_secret.go Outdated
},
},
},
"tags": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/terraform-providers/terraform-provider-aws/blob/44af183718e5ddf44de518a04fd858f84cb350df/aws/tags.go#L20:6

should this use the common schema?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! Will update. 👍

@bflad bflad added this to the v1.16.0 milestone Apr 24, 2018
@ghost ghost added the size/XXL Managed by automation to categorize the size of a PR. label Apr 24, 2018
@bflad bflad merged commit b1a915b into master Apr 24, 2018
@bflad bflad deleted the f-aws_secretsmanager_secret branch April 24, 2018 16:52
bflad added a commit that referenced this pull request Apr 24, 2018
@bflad
Update CHANGELOG for #4272
c134b1d
@bflad
Copy link
Contributor Author

bflad commented Apr 25, 2018

This has been released in version 1.16.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paultyng paultyng paultyng approved these changes

Assignees
No one assigned
Labels
new-data-source Introduces a new data source. new-resource Introduces a new resource. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. size/XXL Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.16.0
Development

Successfully merging this pull request may close these issues.

Feature Request: Support AWS Secrets Manager Secrets
2 participants
@bflad @paultyng