data-source/iam_instance_profile: export attributes role_arn and role_name

[loivis]

fix #4080

As arn and name are most likely concerned when reading instance profile.

  make fmt; and echo > aws/debug.log ; and make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataSourceIAMInstanceProfile_basic'
gofmt -w $(find . -name '*.go' |grep -v vendor)
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSDataSourceIAMInstanceProfile_basic -timeout 120m
=== RUN   TestAccAWSDataSourceIAMInstanceProfile_basic
--- PASS: TestAccAWSDataSourceIAMInstanceProfile_basic (41.35s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	41.413s

[bflad]

Thanks for this! 😄 LGTM and I'll fix the two items below on merge.

=== RUN   TestAccAWSDataSourceIAMInstanceProfile_basic
--- PASS: TestAccAWSDataSourceIAMInstanceProfile_basic (12.58s)

[bflad]

We should perform a len() test to prevent a panic if for some reason instanceProfile.Roles has no elements.

if len(instanceProfile.Roles) > 0 {
  role := instanceProfile.Roles[0]
  d.Set("role_arn", role.Arn)
  d.Set("role_id", role.RoleId)
  d.Set("role_name", role.RoleName)
}

[loivis]

So we can't always trust aws as we've seen quite a few times 😆

[bflad]

Thanks for adjusting this to be more concise! A maintainability note: we should allow other AWS partitions for acceptance testing in aws-cn/aws-us-gov. Easiest way is: ^arn:[^:]+:...

[loivis]

good to know. thanks 😄

[bflad]

This has been released in version 1.16.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!